Merge branch 'master' into help_pages_add_improve_german_translations

Author: SarahW91

CHANGES.rst

@@ -2,14 +2,102 @@
     Copyright (C) 2019-2025 CERN.
     Copyright (C) 2019-2024 Northwestern University.
     Copyright (C) 2021-2024 TU Wien.
-    Copyright (C) 2021-2025 Graz University of Technology.
+    Copyright (C) 2021-2026 Graz University of Technology.
 
     Invenio App RDM is free software; you can redistribute it and/or modify
     it under the terms of the MIT License; see LICENSE file for more details.
 
 Changes
 =======
 
+Version v14.0.0b5.dev0 (released 2026-02-03)
+
+- fix(chore): DeprecationWarning stdlib
+- chore(setup): bump dependencies
+- fix: manage record link functionality for all versions
+- feat(css): styles for deep-linked request comment replies
+- style: collapsible messages style
+- Fix regex search example URL
+- Fix regex search example
+- search guide: fix regex example in swedish translation
+- search guide: fix regex example
+
+Version v14.0.0b4.dev6 released 2026-01-22)
+
+- fix(ExportDropdown): Fix css spacing and responsiveness
+
+Version v14.0.0b4.dev5 (released 2026-01-21)
+
+- feat(CopyButton): Pass remaining props to customize UI & functionality
+- refactor(RecordVersionsList): Make version items overridable
+
+Version v14.0.0b4.dev4 (released 2026-01-15)
+
+- refactor(ui): support custom file display name resolver
+- fix: use UUID type for request identifiers
+- feat(comment-replies): add single threading on comments
+- fix(moderation.requests): handle empty payload key not in request
+- feat(previewer): show message for outdated records
+
+Version v14.0.0b4.dev3 (released 2025-12-18)
+
+- fix(feed): styling for disabled reply input
+
+Version v14.0.0b4.dev2 (released 2025-12-16)
+
+- semantic-ui: feed.overrides: Add placeholder css
+- fix: css padding for preview msg
+
+Version v14.0.0b4.dev1 (released 2025-12-13)
+
+- feat(css): styles for threaded replies
+- feat(views-request): include `can_reply_comment` in template permissions dict
+
+Version v14.0.0b4.dev0 (released 2025-12-12)
+
+- chore(setup): bump major versions
+- feat: add empty Overridable container before and after the files accordion
+- assets: added css for hidden comment line and last page first comment
+
+Version v14.0.0b3.dev4 (released 2025-12-08)
+
+- fix: ensure that pages render if accessed via secret link
+- UI: change button icon and text
+- chore: drill recordRequests into the modal
+- fix: restrict to only community sub/inc reqs
+- frontend: add direct link to request if user has access
+- feat(css): styles for quote replies
+- fix(requests_ui): Inject lock_request and create_comment permissions
+- fix: correct types
+
+Version v14.0.0b3.dev3 (released 2025-11-21)
+
+- feat(css): request comment deep links
+
+Version v14.0.0b3.dev2 (released 2025-11-21)
+
+- fix: revert mapping.js symlink
+
+Version v14.0.0b3.dev1 (released 2025-11-21)
+
+- UI: add info message about remaining days to publish changes
+- request: add file mod request template
+- fix: set files_locked to `bucket.locked` rather than permission
+    * currently the permission is whether you can unlock the files
+    * but the files are only unlocked when you create the draft
+    * as such as an admin when you edit a published draft, if it was
+      created by a user it will look like the files are unlocked but
+      this is false
+- feat: pass file modification eval to deposit form
+- fix: align selector with semantic-ui
+- fix(views): pass API record to evaluate record deletion
+- fix(record-ui): do not sanitize additional description in template
+- admin: requests details view improvements
+    - Replace `Record deletion` by `Deletion request for "Record name"`
+    - Link showing all requests for a given user
+- tombstone: add deletion policy
+- Update release date for version v14.0.0b3.dev0
+
 Version v14.0.0b3.dev0 (released 2025-11-12)
 
 - setup: bump major version of `invenio-oauthclient`

invenio_app_rdm/__init__.py

@@ -2,7 +2,7 @@
 #
 # Copyright (C) 2019-2025 CERN.
 # Copyright (C) 2019-2022 Northwestern University.
-# Copyright (C) 2024-2025 Graz University of Technology.
+# Copyright (C) 2024-2026 Graz University of Technology.
 #
 # Invenio App RDM is free software; you can redistribute it and/or modify it
 # under the terms of the MIT License; see LICENSE file for more details.
@@ -17,6 +17,6 @@
 #
 # See PEP 0440 for details - https://www.python.org/dev/peps/pep-0440
 
-__version__ = "14.0.0b3.dev0"
+__version__ = "14.0.0b5.dev0"
 
 __all__ = ("__version__",)

invenio_app_rdm/administration/audit_logs/audit_logs.py

@@ -6,6 +6,7 @@
 # under the terms of the MIT License; see LICENSE file for more details.
 
 """Invenio administration view module for audit logs."""
+
 from flask import current_app
 from invenio_administration.views.base import AdminResourceListView
 from invenio_i18n import lazy_gettext as _

invenio_app_rdm/administration/moderation/requests.py

@@ -138,7 +138,7 @@ def get_context(self, pid_value=None):
             g.identity, current_user
         )["avatar"]
         permissions = []
-        if "reason" in request["payload"]:
+        if "reason" in request.get("payload", {}):
             reason_title = vocabulary_service.read(
                 g.identity,
                 ("removalreasons", request["payload"]["reason"]),

invenio_app_rdm/administration/templates/semantic-ui/invenio_app_rdm/administration/requests_details.html

@@ -29,12 +29,14 @@
             )
         }}
 
-        <div class="twelve wide column mt-10">
-          <p><strong>{{ _("Reason:") }}</strong> {{ invenio_request["payload"]["reason_label"] }}</p>
-          {%- if invenio_request["payload"]["comment"] %}
-            <p><strong>{{ _("Justification:") }}</strong> {{ invenio_request["payload"]["comment"] }}</p>
-          {%- endif %}
-        </div>
+        {%- if "payload" in invenio_request %}
+          <div class="twelve wide column mt-10">
+            <p><strong>{{ _("Reason:") }}</strong> {{ invenio_request["payload"]["reason_label"] }}</p>
+            {%- if invenio_request["payload"]["comment"] %}
+              <p><strong>{{ _("Justification:") }}</strong> {{ invenio_request["payload"]["comment"] }}</p>
+            {%- endif %}
+          </div>
+        {%- endif %}
 
         <div class="ui divider"></div>
       {%- endblock request_header %}

invenio_app_rdm/config.py

@@ -3,7 +3,7 @@
 # Copyright (C) 2019-2025 CERN.
 # Copyright (C) 2019-2020 Northwestern University.
 # Copyright (C) 2021-2025 Graz University of Technology.
-# Copyright (C) 2022-2024 KTH Royal Institute of Technology.
+# Copyright (C) 2022-2025 KTH Royal Institute of Technology.
 # Copyright (C) 2023      TU Wien
 #
 # Invenio App RDM is free software; you can redistribute it and/or modify it
@@ -87,6 +87,7 @@
 from invenio_records_resources.references.entity_resolvers import ServiceResultResolver
 from invenio_requests.notifications.builders import (
     CommentRequestEventCreateNotificationBuilder,
+    CommentRequestEventReplyNotificationBuilder,
 )
 from invenio_requests.resources.requests.config import request_error_handlers
 from invenio_requests.services.requests import facets
@@ -1074,9 +1075,9 @@ def github_link_render(record):
 # ===================
 
 RDM_REQUESTS_ROUTES = {
-    "user-dashboard-request-details": "/me/requests/<request_pid_value>",
-    "community-dashboard-request-details": "/communities/<pid_value>/requests/<request_pid_value>",
-    "community-dashboard-invitation-details": "/communities/<pid_value>/invitations/<request_pid_value>",
+    "user-dashboard-request-details": "/me/requests/<uuid:request_pid_value>",
+    "community-dashboard-request-details": "/communities/<pid_value>/requests/<uuid:request_pid_value>",
+    "community-dashboard-invitation-details": "/communities/<pid_value>/invitations/<uuid:request_pid_value>",
 }
 
 RDM_COMMUNITIES_ROUTES = {
@@ -1172,6 +1173,9 @@ def github_link_render(record):
 ]
 """Preferred previewers."""
 
+PREVIEWER_ABSTRACT_TEMPLATE = "invenio_previewer/rdm_abstract_previewer.html"
+"""Override the abstract template with an RDM-specific one."""
+
 RECORDS_RESOURCES_IMAGE_FORMATS = ["." + ext for ext in IIIF_FORMATS.keys()]
 """RECORDS_RESOURCES_IMAGE_FORMATS must contain all possible IIIF formats to ensure their metadata is extracted."""
 
@@ -1404,6 +1408,7 @@ def github_link_render(record):
     GrantUserAccessNotificationBuilder.type: GrantUserAccessNotificationBuilder,
     # Comment request event
     CommentRequestEventCreateNotificationBuilder.type: CommentRequestEventCreateNotificationBuilder,
+    CommentRequestEventReplyNotificationBuilder.type: CommentRequestEventReplyNotificationBuilder,
     community_notifications.SubComReqCommentNotificationBuilder.type: community_notifications.SubComReqCommentNotificationBuilder,
     community_notifications.SubComInvCommentNotificationBuilder.type: community_notifications.SubComInvCommentNotificationBuilder,
     # Community inclusion

invenio_app_rdm/records_ui/templates/semantic-ui/invenio_app_rdm/records/deposit.html

@@ -51,6 +51,9 @@
   {% if record_deletion %}
     <input type="hidden" name="deposits-record-deletion" value='{{ record_deletion | tojson }}'>
   {% endif %}
+  {% if file_modification %}
+    <input type="hidden" name="deposits-file-modification" value='{{ file_modification | tojson }}'>
+  {% endif %}
   <input type="hidden" name="config-groups-enabled"
           value='{{ config.USERS_RESOURCES_GROUPS_ENABLED | tojson }}'>
   <input type="hidden" name="records-resources-allow-empty-files"

invenio_app_rdm/records_ui/templates/semantic-ui/invenio_app_rdm/records/detail.html

@@ -4,7 +4,7 @@
   Copyright (C) 2021-2023 TU Wien.
   Copyright (C) 2021 Graz University of Technology.
   Copyright (C) 2021 New York University.
-  Copyright (C) 2024 KTH Royal Institute of Technology.
+  Copyright (C) 2024-2025 KTH Royal Institute of Technology.
 
   Invenio RDM Records is free software; you can redistribute it and/or modify
   it under the terms of the MIT License; see LICENSE file for more details.
@@ -26,6 +26,9 @@
 {%- set title = record_ui["metadata"]["title"] %}
 {%- set metadata = record_ui["metadata"] %}
 
+<!-- Shared namespace for files to allow overridability on child blocks while maintaining reference to parent values -->
+{% set files_ns = namespace(preview_file=None, files=[]) %}
+
 {%- set can_curate_record = permissions is defined and (permissions.can_edit or permissions.can_review) %}
 
 <!-- preview_submission_request is set to true when coming from a community submission request -->
@@ -107,7 +110,7 @@
 
     <!-- PREVIEW HEADER -->
     {% if is_preview %}
-      <div class="ui info flashed bottom attached manage message">
+      <div class="ui info bottom attached manage message">
         <div class="ui container">
           <div class="header">
             <i class="eye icon"></i>
@@ -288,14 +291,19 @@
                          aria-label="{{ _('Files') }}">
                   {%- if permissions.can_read_files -%}
                     {# record has files AND user can see files #}
-                    {%- set files = files | order_entries | selectattr("status", "==", "completed") | list %}
-                    {%- if files|length > 0 -%}
+                    {# Shared namespace for files (outside blocks) #}
+                    {%- set files_ns.files = files | order_entries | selectattr("status", "==", "completed") | list %}
+                    {%- if files_ns.files|length > 0 -%}
                       <h2 id="files-heading">{{ _('Files') }}</h2>
-                      {%- if files|has_previewable_files -%}
-                        {%-set preview_file = files|select_preview_file(default_preview=record_ui["files"]["default_preview"]) %}
-                        {{ preview_file_box(preview_file, record_ui["id"], is_preview, record, include_deleted) }}
+                      {%- if files_ns.files|has_previewable_files -%}
+                        {%-set files_ns.preview_file = files_ns.files|select_preview_file(default_preview=record_ui["files"]["default_preview"]) %}
+                        {%- block record_file_preview -%}
+                          {{ preview_file_box(files_ns.preview_file, record_ui["id"], is_preview, record, include_deleted) }}
+                        {%- endblock record_file_preview -%}
                       {%- endif -%}
-                      {{ file_list_box(files, record_ui["id"], is_preview, include_deleted, record, permissions) }}
+                      {%- block record_file_list -%}
+                        {{ file_list_box(files_ns.files, record_ui["id"], is_preview, include_deleted, record, permissions) }}
+                      {%- endblock record_file_list -%}
                     {% endif %}
                   {% else %}
                     {# record has files BUT user does not have permission to see files #}

invenio_app_rdm/records_ui/templates/semantic-ui/invenio_app_rdm/records/details/side_bar/communities.html

@@ -9,6 +9,7 @@
   data-pending-communities-search-config='{{ search_app_rdm_record_requests_config(app_id="InvenioAppRdm.RecordRequests", endpoint=record_ui["links"]["requests"]) | tojson }}'
   data-permissions='{{ permissions | tojson }}'
   data-record='{{ record_ui | tojson }}'
+  data-record-requests='{{ record_requests | default({}) | tojson }}'
   class='sidebar-container'
 >
 

invenio_app_rdm/records_ui/templates/semantic-ui/invenio_app_rdm/records/macros/files.html

@@ -31,8 +31,13 @@
 {%- endmacro %}
 
 
-{% macro preview_file_box(file, pid, is_preview, record, include_deleted) %}
+{% macro preview_file_box(file, pid, is_preview, record, include_deleted, display_name=None) %}
   {%- set is_remote_file = file.transfer.type == transfer_types.REMOTE %}
+  {%- if display_name %}
+    {%- set human_readable_file_name = display_name(file) or file.key %}
+  {%- else %}
+    {%- set human_readable_file_name = file.key %}
+  {%- endif %}
   <div class="ui accordion panel mb-10 {{record.ui.access_status.id}}" href="#files-preview-accordion-panel">
     <h3 class="active title panel-heading {{ record.ui.access_status.id }} m-0">
       <div
@@ -44,7 +49,7 @@ <h3 class="active title panel-heading {{ record.ui.access_status.id }} m-0">
         class="trigger"
         aria-label="{{ _('File preview') }}"
       >
-        <span id="preview-file-title">{{ file.key }}</span>
+        <span id="preview-file-title">{{ human_readable_file_name }}</span>
         <i class="angle right icon" aria-hidden="true"></i>
       </div>
     </h3>
@@ -82,9 +87,10 @@ <h3 class="active title panel-heading {{ record.ui.access_status.id }} m-0">
     download_endpoint='invenio_app_rdm_records.record_file_download',
     preview_endpoint='invenio_app_rdm_records.record_file_preview',
     is_media=false,
-    permissions=None
+    permissions=None,
+    display_name=None
 ) %}
-  <table class="ui striped table files fluid {{record.ui.access_status.id}}">
+  <table id="file-list-table" class="ui striped table files fluid {{record.ui.access_status.id}}">
     <thead>
       <tr>
         <th>{{_('Name')}}</th>
@@ -108,6 +114,11 @@ <h3 class="active title panel-heading {{ record.ui.access_status.id }} m-0">
     {% for file in files %}
       {% if not file.access.hidden %}
         {%- set is_remote_file = file.transfer.type == transfer_types.REMOTE %}
+        {%- if display_name %}
+          {%- set human_readable_file_name = display_name(file) or file.key %}
+        {%- else %}
+          {%- set human_readable_file_name = file.key %}
+        {%- endif %}
         {% if is_preview %}
           {%- set file_url_download = url_for(download_endpoint, pid_value=pid, filename=file.key, download=1, preview=1) %}
           {%- set file_url_preview = url_for(preview_endpoint, pid_value=pid, filename=file.key, preview=1, include_deleted=include_deleted_value) %}
@@ -120,7 +131,7 @@ <h3 class="active title panel-heading {{ record.ui.access_status.id }} m-0">
         <tr>
           <td class="ten wide">
             <div>
-              <a href="{{ file_url_download }}">{{ file.key }}</a>
+              <a href="{{ file_url_download }}">{{ human_readable_file_name }}</a>
             </div>
             {%- if not is_remote_file %}
             <small class="ui text-muted font-tiny">{{ file.checksum or _("Checksum not yet calculated.") }}
@@ -151,7 +162,7 @@ <h3 class="active title panel-heading {{ record.ui.access_status.id }} m-0">
 {%- endmacro %}
 
 
-{% macro file_list_box(files, pid, is_preview, include_deleted, record, permissions) %}
+{% macro file_list_box(files, pid, is_preview, include_deleted, record, permissions, display_name=None) %}
   {%- set binary_sizes = not config.APP_RDM_DISPLAY_DECIMAL_FILE_SIZES %}
   <div class="ui accordion panel mb-10 {{ record.ui.access_status.id }}" href="#files-list-accordion-panel">
     <h3 class="active title panel-heading {{ record.ui.access_status.id }} m-0">
@@ -174,13 +185,13 @@ <h4 class="inline">{{ record.ui.access_status.title_l10n }}</h4>
         </div>
       {% endif %}
       <div>
-        {{ file_list(files, pid, is_preview, include_deleted, record=record,download_endpoint="invenio_app_rdm_records.record_file_download", permissions=permissions) }}
+        {{ file_list(files, pid, is_preview, include_deleted, record=record,download_endpoint="invenio_app_rdm_records.record_file_download", permissions=permissions, display_name=display_name) }}
       </div>
     </div>
   </div>
 {%- endmacro %}
 
-{% macro media_file_list_box(files, pid, is_preview, include_deleted, record, permissions) %}
+{% macro media_file_list_box(files, pid, is_preview, include_deleted, record, permissions, display_name=None) %}
   {%- set binary_sizes = not config.APP_RDM_DISPLAY_DECIMAL_FILE_SIZES %}
   <div class="ui accordion panel mb-10 {{ record.access.record }}" href="#media-files-preview-accordion-panel">
     <h3 class="active title panel-heading {{ record.access.record }} m-0">
@@ -204,7 +215,7 @@ <h4 class="inline">{{ record.ui.access_status.title_l10n }}</h4>
         </div>
       {% endif %}
       <div>
-        {{ file_list(files, pid, is_preview, include_deleted, record=record, with_preview=false, download_endpoint="invenio_app_rdm_records.record_media_file_download", is_media=true, permissions=permissions) }}
+        {{ file_list(files, pid, is_preview, include_deleted, record=record, with_preview=false, download_endpoint="invenio_app_rdm_records.record_media_file_download", is_media=true, permissions=permissions, display_name=display_name) }}
       </div>
     </div>
   </div>