selector: check the corner case when one value starts with the same string as another value

Author: psaiz

src/lib/state/selectors/query.js

@@ -18,7 +18,16 @@ import _pick from "lodash/pick";
  * @param {string} second a string
  */
 function startsWith(first, second) {
-  return first.indexOf(second) === 0;
+  /* This is a bit tricky, since the verification should distinguish between the label and the children
+  In other words:
+  * 'q=type:hello&subtype:there' (or 'q=type:hello') starts with 'q=type:hello'
+  * 'q=type:hello there' should not start with 'q=type:hello'
+  So the check verifies that both terms are the same length, or that there is an '&' as soon as the second finishes
+  */
+  return (
+    first.indexOf(second) === 0 &&
+    (first.length === second.length || first.indexOf(second + "&") === 0)
+  );
 }
 
 function toString(array) {

src/lib/state/selectors/query.test.js

@@ -72,6 +72,18 @@ describe("queries with first level filters.", () => {
       ["type", "Publication"],
     ]);
   });
+
+  test("query with terms that start with the same text", () => {
+    const state = [
+      ["file_type", "pdf"],
+      ["file_type", "pdf2"],
+    ];
+    const query = ["file_type", "pdf"];
+
+    const newState = updateQueryFilters(query, state);
+
+    expect(newState).toEqual([["file_type", "pdf2"]]);
+  });
 });
 
 describe("queries with second level filters.", () => {
@@ -142,6 +154,17 @@ describe("queries with second level filters.", () => {
       ["type", "Publication"],
     ]);
   });
+  test("query with terms that start with the same text and with children", () => {
+    const state = [
+      ["file_type", "pdf", ["sub_type", "image"]],
+      ["file_type", "pdf2"],
+    ];
+    const query = ["file_type", "pdf"];
+
+    const newState = updateQueryFilters(query, state);
+
+    expect(newState).toEqual([["file_type", "pdf2"]]);
+  });
 });
 
 describe("queries with third level filters.", () => {