-
Notifications
You must be signed in to change notification settings - Fork 41
Open
Description
This issue is created to analyse whether SearchBar component can be fully uncontrolled. Right now, its state variable currentValue is initialised based on the prop queryString which is controlled by the component's parent (<SearchBarUncontrolled>).
queryString is a prop currently connected by Redux to the store's state state.query.queryString
The current implementation is updating the component's internal state rather than the redux one.
react-searchkit/src/lib/components/SearchBar/index.js
Lines 17 to 20 in 9274d99
| export const SearchBar = connect( | |
| (state) => ({ | |
| queryString: state.query.queryString, | |
| }), |
Metadata
Metadata
Assignees
Labels
No labels