Initial data in Stock Allocation Form

[AmitEMV]

Hi,

In Allocate Stock modal today, the default selection of an item doesn't happen unless it's the only element in the dropdown. This specific section of code in SalesOrderForms.tsx currently has -

return useCreateApiFormModal({
    ...
    initialData: {
        items: lineItems.map((item) => {
          return {
            line_item: item.pk,
            quantity:  0,
            stock_item: null
          };
        })
      }
  });

A change here can allow the items to be pre-selected in any specific way we want it. We can pass in the items which are oldest, newest or any other business rules that might make sense. The resulting code would be -

return useCreateApiFormModal({
    ...
    initialData: {
        items: lineItems.map((item) => {
          return {
            line_item: item.pk,
            quantity: item.quantity ?? 0,
            stock_item: item.stock_item ?? null
          };
        })
      }
  });

And we would do this to show this modal -

const allocateStock = useAllocateToSalesOrderForm({
    ...
    lineItems : initData.items,
    onFormSuccess,
  });

where initData has this shape

{
    available_quantity: string;
    // any more fields if needed

   // these 3 are expected/current
    pk: number;
    stock_item: number | null;
    quantity: number;
  }

Would this change be something that can be accepted here or any suggestions if not?

Thanks!

[SchrodingersGat]

@AmitEMV how do you suggest that the actual initial data is determined, via the calling function?

Overall this makes sense, happy for you to submit a working PR and we can discuss further there

[gunstr]

The current implementation has the advantage that the user is forced to do an active selection if there are more than one stockitem. It's not clear how you intend to implement the pre-selection logic but I belevie there are many use cases to handle. If the pre-selection logic is not very flexible and configurable I would appreciate at least a setting to keep the currrent functionality.