How to make dependant fields disappear if other value selected?

[martonmiklos]

I did not wanted to pollute the issue tracker with some development related help, I hope it could fit here.

I am trying to add a custom sheet size option to the label sheet printer plugin:
martonmiklos@dba1a4e#diff-6e924718eac2d314c838bd9e458d9a6d245a20bd486fb1e65cc30415c8eb635dR34

For revealing the fields it works great, however it does not hide them when a predefined size is selected.

Is there anything what I am missing?

I tried to study the machine plugin where it is utilized:
https://github.com/inventree/InvenTree/blob/master/src/backend/InvenTree/plugin/builtin/labels/inventree_machine.py#L165

However I did not found any major differences to my usage.

[martonmiklos]

The hiding partially works in the old UI, however the labels never got hidden (and visible by default):

@wolflu05 would you mind to take a look on this? I am happy to fix this behavior if it is an issue (and not misuse on my side).

[wolflu05]

Hi @martonmiklos,

sorry for not replying today, I was away from the computer the whole day, so it took me some time to get to it. This is really strange behavior and definitely not expected. I tried to analyze the requests, and it seems like this is an issue with the frontend implementation.

1. Initial OPTIONS request, with just the printing plugin selected (no child is provided for the width field):
   

2. Selecting "Custom" page size (child with Integer Serializer is provided):
   

3. And again, selecting A4 (again like the first request, no child for the width field is provided):
   

I would really appreciate it if you could find a fix for it and make a PR, I currently sadly have no time for fixing this.

[martonmiklos]

@wolflu05 no worries, many thanks for the quick feedback and for looking into it.
I will try to fix it and came up with a PR.