ExpressAdapter mixing useGlobalFilters and raw express error handler

[egmacke]

I am working on migrating an application to the new @inversifyjs/http libraries from invesify-express-utils.

We have an application which hosts 2 APIs

• One managed by an InversifyExpressHttpAdapter
• One managed separately (a legacy component that is mounted into express from an external library)

We need to provide a layer of generic error handling that can catch certain errors from either API. We also need a layer of generic middleware to service both sets of endpoints (could also extend into guards).

I've been looking into using global error filters and global middleware, but have realised that they only apply to routes mounted into the inversify express adapter,

Is there a recommended way of handling this use case, or should I just keep using pure express middleware/error handlers?

Additionally, I think it would be useful to update the docs to clarify that global ErrorFilters will only apply to inversify managed routes:

[notaphplover]

Hey @egmacke,

I've been looking into using global error filters and global middleware, but have realised that they only apply to routes mounted into the inversify express adapter,

Yeah, that's correct. That's the intended behavior. We prefer to operate in the scope of the adapter in order to avoid unexpected side effects.

Is there a recommended way of handling this use case, or should I just keep using pure express middleware/error handlers?

Mhmm I don't think there's a recommended way in this case, if using a pure express middleware solves your issue I would go for it. At first glance I don't see a straighforward way to go using the inversify adapter, and using both inversify and pure express middlewares could be worse. You can use inversify to easily build pure express middlewares in case middlewares have dependencies. I'll give it some thought.

Additionally, I think it would be useful to update the docs to clarify that global ErrorFilters will only apply to inversify managed routes

You're absolutelly right, I'll go for it soon :)