Support analyzer 6.6.0 (#266)

Author: rrousselGit

all_lint_rules.yaml

@@ -3,10 +3,10 @@ linter:
     - always_declare_return_types
     - always_put_control_body_on_new_line
     - always_put_required_named_parameters_first
-    - always_require_non_null_named_parameters
     - always_specify_types
     - always_use_package_imports
     - annotate_overrides
+    - annotate_redeclares
     - avoid_annotating_with_dynamic
     - avoid_bool_literals_in_conditional_expressions
     - avoid_catches_without_on_clauses
@@ -18,6 +18,7 @@ linter:
     - avoid_equals_and_hash_code_on_mutable_classes
     - avoid_escaping_inner_quotes
     - avoid_field_initializers_in_const_classes
+    - avoid_final_parameters
     - avoid_function_literals_in_foreach_calls
     - avoid_implementing_value_types
     - avoid_init_to_null
@@ -31,8 +32,6 @@ linter:
     - avoid_relative_lib_imports
     - avoid_renaming_method_parameters
     - avoid_return_types_on_setters
-    - avoid_returning_null
-    - avoid_returning_null_for_future
     - avoid_returning_null_for_void
     - avoid_returning_this
     - avoid_setters_without_getters
@@ -53,39 +52,56 @@ linter:
     - cascade_invocations
     - cast_nullable_to_non_nullable
     - close_sinks
+    - collection_methods_unrelated_type
+    - combinators_ordering
     - comment_references
+    - conditional_uri_does_not_exist
     - constant_identifier_names
     - control_flow_in_finally
     - curly_braces_in_flow_control_structures
+    - dangling_library_doc_comments
     - depend_on_referenced_packages
     - deprecated_consistency
+    - deprecated_member_use_from_same_package
     - diagnostic_describe_all_properties
     - directives_ordering
+    - discarded_futures
     - do_not_use_environment
+    - document_ignores
     - empty_catches
     - empty_constructor_bodies
     - empty_statements
+    - eol_at_end_of_file
     - exhaustive_cases
     - file_names
     - flutter_style_todos
     - hash_and_equals
     - implementation_imports
-    - invariant_booleans
-    - iterable_contains_unrelated_type
+    - implicit_call_tearoffs
+    - implicit_reopen
+    - invalid_case_patterns
+    - invalid_runtime_check_with_js_interop_types
     - join_return_with_assignment
     - leading_newlines_in_multiline_strings
+    - library_annotations
     - library_names
     - library_prefixes
     - library_private_types_in_public_api
     - lines_longer_than_80_chars
-    - list_remove_unrelated_type
     - literal_only_boolean_expressions
+    - matching_super_parameters
+    - missing_code_block_language_in_doc_comment
     - missing_whitespace_between_adjacent_strings
     - no_adjacent_strings_in_list
     - no_default_cases
     - no_duplicate_case_values
+    - no_leading_underscores_for_library_prefixes
+    - no_leading_underscores_for_local_identifiers
+    - no_literal_bool_comparisons
     - no_logic_in_create_state
     - no_runtimeType_toString
+    - no_self_assignments
+    - no_wildcard_variable_uses
     - non_constant_identifier_names
     - noop_primitive_operations
     - null_check_on_nullable_type_parameter
@@ -110,7 +126,6 @@ linter:
     - prefer_constructors_over_static_methods
     - prefer_contains
     - prefer_double_quotes
-    - prefer_equal_for_default_values
     - prefer_expression_function_bodies
     - prefer_final_fields
     - prefer_final_in_for_each
@@ -142,7 +157,9 @@ linter:
     - public_member_api_docs
     - recursive_getters
     - require_trailing_commas
+    - secure_pubspec_urls
     - sized_box_for_whitespace
+    - sized_box_shrink_expand
     - slash_for_doc_comments
     - sort_child_properties_last
     - sort_constructors_first
@@ -153,15 +170,23 @@ linter:
     - tighten_type_of_initializing_formals
     - type_annotate_public_apis
     - type_init_formals
+    - type_literal_in_constant_pattern
     - unawaited_futures
+    - unintended_html_in_doc_comment
     - unnecessary_await_in_return
     - unnecessary_brace_in_string_interps
+    - unnecessary_breaks
     - unnecessary_const
+    - unnecessary_constructor_name
     - unnecessary_final
     - unnecessary_getters_setters
     - unnecessary_lambdas
+    - unnecessary_late
+    - unnecessary_library_directive
+    - unnecessary_library_name
     - unnecessary_new
     - unnecessary_null_aware_assignments
+    - unnecessary_null_aware_operator_on_extension_on_nullable
     - unnecessary_null_checks
     - unnecessary_null_in_if_null_operators
     - unnecessary_nullable_for_final_variable_declarations
@@ -172,9 +197,14 @@ linter:
     - unnecessary_string_escapes
     - unnecessary_string_interpolations
     - unnecessary_this
+    - unnecessary_to_list_in_spreads
+    - unreachable_from_main
     - unrelated_type_equality_checks
     - unsafe_html
     - use_build_context_synchronously
+    - use_colored_box
+    - use_decorated_box
+    - use_enums
     - use_full_hex_values_for_flutter_colors
     - use_function_type_syntax_for_parameters
     - use_if_null_to_convert_nulls_to_bools
@@ -186,6 +216,8 @@ linter:
     - use_rethrow_when_possible
     - use_setters_to_change_properties
     - use_string_buffers
+    - use_string_in_part_of_directives
+    - use_super_parameters
     - use_test_throws_matchers
     - use_to_and_as_if_applicable
     - valid_regexps

packages/custom_lint/.gitignore renamed to packages/custom_lint/.pubignore

@@ -1,6 +1,9 @@
-## Unreleased fix
+## Unreleased 0.7.0-dev.0
 
-- Fix compilation error when using latest analyzer
+- Upgraded to analyzer ^6.6.0.
+  This is a quick fix to unblock the stable Flutter channel.
+  A more robust fix will come later.
+- Fixed a bug where isSuperTypeOf throws if the element is null (thanks to @charlescyt)
 
 ## 0.6.4 - 2024-03-16
 

packages/custom_lint/CHANGELOG.md

@@ -8,3 +8,4 @@ linter:
   rules:
     public_member_api_docs: false
     avoid_print: false
+    unreachable_from_main: false

packages/custom_lint/example/analysis_options.yaml

@@ -68,7 +68,7 @@ class PreferFinalProviders extends DartLintRule {
       }
 
       // This emits our lint warning at the location of the variable.
-      reporter.reportErrorForElement(code, element);
+      reporter.atElement(element, code);
     });
   }
 

packages/custom_lint/example/example_lint/lib/custom_lint_example_lint.dart

@@ -9,7 +9,6 @@ class Main {}
 // expect_lint: riverpod_final_provider
 ProviderBase<int> provider = Provider((ref) => 0);
 
-// expect_lint: riverpod_final_provider
 Provider<int> provider2 = Provider((ref) => 0);
 
 Object? foo = 42;

packages/custom_lint/example/lib/main.dart

@@ -1,4 +1,4 @@
 @Deprecated('Import `package:custom_lint/custom_lint.dart` instead')
-library basic_runner;
+library;
 
 export 'custom_lint.dart';

packages/custom_lint/lib/basic_runner.dart

@@ -189,7 +189,6 @@ Future<void> _startWatchMode(
           fatalWarnings: fatalWarnings,
           format: format,
         );
-        break;
       case 'q':
         // Let's quit the command line
         return;

packages/custom_lint/lib/custom_lint.dart

@@ -7,10 +7,10 @@ import 'plugin_delegate.dart';
 import 'v2/custom_lint_analyzer_plugin.dart';
 
 /// Connects custom_lint to the analyzer server using the analyzer_plugin protocol
-void start(Iterable<String> _, SendPort sendPort) {
+Future<void> start(Iterable<String> _, SendPort sendPort) async {
   final isInCI = ci.isCI;
 
-  CustomLintServer.start(
+  await CustomLintServer.start(
     sendPort: sendPort,
     includeBuiltInLints: true,
     // The IDE client should write to files, as what's visible in the editor

packages/custom_lint/lib/src/analyzer_plugin_starter.dart

@@ -1,7 +1,7 @@
 import 'package:analyzer/file_system/file_system.dart';
-// ignore: implementation_imports
+// ignore: implementation_imports, not exported
 import 'package:analyzer/src/dart/analysis/byte_store.dart';
-// ignore: implementation_imports
+// ignore: implementation_imports, not exported
 import 'package:analyzer/src/dart/analysis/file_byte_store.dart';
 
 /// Adds [createByteStore].