feat: add config severities

Author: Artur-Wisniewski

packages/custom_lint_builder/lib/src/client.dart

@@ -995,6 +995,7 @@ class _ClientAnalyzerPlugin extends analyzer_plugin.ServerPlugin {
               allAnalysisErrors,
               lineInfo: resolver.lineInfo,
               options: analysisContext.getAnalysisOptionsForFile(file),
+              configSeverities: configs.configs.errors,
             ),
           ).toNotification(),
         ),

packages/custom_lint_builder/lib/src/custom_analyzer_converter.dart

@@ -72,22 +72,35 @@ class CustomAnalyzerConverter {
   /// start column. If an analysis [options] is provided then the severities of
   /// the errors will be altered based on those options.
   List<plugin.AnalysisError> convertAnalysisErrors(
-      List<analyzer.AnalysisError> errors,
-      {analyzer.LineInfo? lineInfo,
-      analyzer.AnalysisOptions? options}) {
+    List<analyzer.AnalysisError> errors, {
+    analyzer.LineInfo? lineInfo,
+    analyzer.AnalysisOptions? options,
+    Map<String, analyzer.ErrorSeverity>? configSeverities,
+  }) {
     var serverErrors = <plugin.AnalysisError>[];
     for (var error in errors) {
       var processor = analyzer.ErrorProcessor.getProcessor(options, error);
+      // Check if there's a severity override in the configs
+      final configSeverity = configSeverities?[error.errorCode.name];
+
       if (processor != null) {
         var severity = processor.severity;
         // Errors with null severity are filtered out.
         if (severity != null) {
-          // Specified severities override.
-          serverErrors.add(convertAnalysisError(error,
-              lineInfo: lineInfo, severity: severity));
+          // Config severities override processor severities
+          serverErrors.add(convertAnalysisError(
+            error,
+            lineInfo: lineInfo,
+            severity: configSeverity ?? severity,
+          ));
         }
       } else {
-        serverErrors.add(convertAnalysisError(error, lineInfo: lineInfo));
+        // If no processor, still check for config severities
+        serverErrors.add(convertAnalysisError(
+          error,
+          lineInfo: lineInfo,
+          severity: configSeverity,
+        ));
       }
     }
     return serverErrors;

packages/custom_lint_core/lib/src/configs.dart

@@ -1,3 +1,4 @@
+import 'package:analyzer/error/error.dart';
 import 'package:analyzer/file_system/file_system.dart';
 import 'package:collection/collection.dart';
 import 'package:meta/meta.dart';
@@ -17,6 +18,7 @@ class CustomLintConfigs {
     required this.verbose,
     required this.debug,
     required this.rules,
+    required this.errors,
   });
 
   /// Decode a [CustomLintConfigs] from a file.
@@ -108,11 +110,33 @@ class CustomLintConfigs {
       }
     }
 
+    final errors = <String, ErrorSeverity>{...includedOptions.errors};
+
+    final errorsYaml = customLint['errors'] as Object?;
+    if (errorsYaml is Map) {
+      for (final entry in errorsYaml.entries) {
+        final value = entry.value;
+        if (entry.key case final String key?) {
+          final severity = ErrorSeverity.values.firstWhereOrNull(
+            (e) => e.displayName == value,
+          );
+          if (severity == null) {
+            throw ArgumentError(
+              'Provided error severity: $value specified for key: $key is not valid. '
+              'Valid error severities are: ${ErrorSeverity.values.map((e) => e.displayName).join(', ')}',
+            );
+          }
+          errors[key] = severity;
+        }
+      }
+    }
+
     return CustomLintConfigs(
       enableAllLintRules: enableAllLintRules,
       verbose: verbose,
       debug: debug,
       rules: UnmodifiableMapView(rules),
+      errors: UnmodifiableMapView(errors),
     );
   }
 
@@ -123,6 +147,7 @@ class CustomLintConfigs {
     verbose: false,
     debug: false,
     rules: {},
+    errors: {},
   );
 
   /// A field representing whether to enable/disable lint rules that are not
@@ -147,20 +172,26 @@ class CustomLintConfigs {
   /// Whether enable hot-reload and log the VM-service URI.
   final bool debug;
 
+  /// A map of lint rules to their severity. This is used to override the severity
+  /// of a lint rule for a specific lint.
+  final Map<String, ErrorSeverity> errors;
+
   @override
   bool operator ==(Object other) =>
       other is CustomLintConfigs &&
       other.enableAllLintRules == enableAllLintRules &&
       other.verbose == verbose &&
       other.debug == debug &&
-      const MapEquality<String, LintOptions>().equals(other.rules, rules);
+      const MapEquality<String, LintOptions>().equals(other.rules, rules) &&
+      const MapEquality<String, ErrorSeverity>().equals(other.errors, errors);
 
   @override
   int get hashCode => Object.hash(
         enableAllLintRules,
         verbose,
         debug,
         const MapEquality<String, LintOptions>().hash(rules),
+        const MapEquality<String, ErrorSeverity>().hash(errors),
       );
 }