Allow pub get execution on Windows platforms (#240)

Author: srtonz

packages/custom_lint/lib/src/workspace.dart

@@ -114,7 +114,9 @@ String _buildDependencyConstraint(
     case HostedDependency():
       return ' ${sharedConstraint.getDisplayString()}';
     case PathDependency():
-      return '\n    path: "${sharedConstraint.path}"';
+      // Use appropriate path separators across platforms
+      final path = posix.prettyUri(sharedConstraint.path);
+      return '\n    path: "$path"';
     case SdkDependency():
       return '\n    sdk: ${sharedConstraint.sdk}';
     case GitDependency():
@@ -391,6 +393,10 @@ typedef RunProcess = Future<ProcessResult> Function(
 @visibleForTesting
 RunProcess runProcess = Process.run;
 
+/// Allow mocking of the platform for tests.
+@visibleForTesting
+bool platformIsWindows = Platform.isWindows;
+
 /// An error thrown when [CustomLintPlugin._visitSelfAndTransitiveDependencies] tries to iterate over
 /// the dependencies of a package, but the package cannot be found in
 /// the `package_config.json`.
@@ -836,6 +842,7 @@ publish_to: 'none'
       stdoutEncoding: utf8,
       stderrEncoding: utf8,
       workingDirectory: tempDir.path,
+      runInShell: platformIsWindows,
     );
     if (result.exitCode != 0) {
       throw Exception(

packages/custom_lint/test/src/workspace_test.dart

@@ -93,8 +93,9 @@ void mockProcess(RunProcess mock) {
   runProcess = mock;
 }
 
-Queue<({String executable, List<String> args})> spyProcess() {
-  final result = Queue<({String executable, List<String> args})>();
+Queue<({String executable, List<String> args, bool runInShell})> spyProcess() {
+  final result =
+      Queue<({String executable, List<String> args, bool runInShell})>();
 
   final previousRunProcess = runProcess;
   addTearDown(() => runProcess = previousRunProcess);
@@ -108,7 +109,8 @@ Queue<({String executable, List<String> args})> spyProcess() {
     stdoutEncoding,
     workingDirectory,
   }) {
-    result.add((executable: executable, args: arguments));
+    result
+        .add((executable: executable, args: arguments, runInShell: runInShell));
 
     return previousRunProcess(
       executable,
@@ -813,12 +815,12 @@ environment:
 
 dev_dependencies:
   plugin1:
-    path: "${workingDir.dir('plugin1').path}"
+    path: "${p.posix.prettyUri(workingDir.dir('plugin1').path)}"
 ''');
         expect(tempDir.pubspecOverrides.readAsStringSync(), '''
 dependency_overrides:
   plugin1:
-    path: "${workingDir.dir('plugin1').path}"
+    path: "${p.posix.prettyUri(workingDir.dir('plugin1').path)}"
 ''');
       });
 
@@ -1110,6 +1112,37 @@ dependency_overrides:
         );
         expect(processes, isEmpty);
       });
+
+      test('only spawns a shell when running in Windows', () async {
+        final workingDir = await createSimpleWorkspace([
+          'custom_lint_builder',
+          Pubspec(
+            'plugin1',
+            environment: {'sdk': VersionConstraint.parse('^3.0.0')},
+            dependencies: {'custom_lint_builder': HostedDependency()},
+          ),
+          Pubspec(
+            'a',
+            environment: {'sdk': VersionConstraint.parse('^3.0.0')},
+            devDependencies: {'plugin1': PathDependency('../plugin1')},
+          ),
+        ]);
+
+        final workspace = await fromContextRootsFromPaths(
+          ['a'],
+          workingDirectory: workingDir,
+        );
+
+        final processes = spyProcess();
+
+        platformIsWindows = true;
+        await workspace.runPubGet(workingDir.dir('a'));
+        expect(processes.last.runInShell, true);
+
+        platformIsWindows = false;
+        await workspace.runPubGet(workingDir.dir('a'));
+        expect(processes.last.runInShell, false);
+      });
     });
 
     group('isUsingFlutter', () {
@@ -1718,7 +1751,7 @@ publish_to: 'none'
 
 dev_dependencies:
   plugin1:
-    path: "${workingDir.dir('plugin1').path}"
+    path: "${p.posix.prettyUri(workingDir.dir('plugin1').path)}"
 ''');
       });