Skip to content

Commit 9139b1f

Browse files
committed
remove TODOs
1 parent 3b0fdab commit 9139b1f

File tree

1 file changed

+0
-8
lines changed

1 file changed

+0
-8
lines changed

packages/dart_firebase_admin/test/app/firebase_app_test.dart

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -267,8 +267,6 @@ void main() {
267267
// await FirebaseApp.deleteApp(app);
268268
// });
269269

270-
// TODO(demolaf): fails in CI in PRs because of CREDS as
271-
// gcloud auth application-default login fails
272270
test('reuses same client on subsequent calls', () {
273271
runZoned(() async {
274272
final mockClient = MockAuthClient();
@@ -309,16 +307,12 @@ void main() {
309307
}
310308
});
311309

312-
// TODO(demolaf): fails in CI in PRs because of CREDS as
313-
// gcloud auth application-default login fails
314310
test('appCheck returns AppCheck instance', () {
315311
final appCheck = app.appCheck();
316312
expect(appCheck, isA<AppCheck>());
317313
expect(identical(appCheck.app, app), isTrue);
318314
});
319315

320-
// TODO(demolaf): fails in CI in PRs because of CREDS as
321-
// gcloud auth application-default login fails
322316
test('appCheck returns cached instance', () {
323317
final appCheck1 = app.appCheck();
324318
final appCheck2 = app.appCheck();
@@ -475,8 +469,6 @@ void main() {
475469
expect(app.isDeleted, isTrue);
476470
});
477471

478-
// TODO(demolaf): fails in CI in PRs because of CREDS as
479-
// gcloud auth application-default login fails
480472
test('closes HTTP client when created by SDK', () {
481473
runZoned(() async {
482474
final mockClient = MockAuthClient();

0 commit comments

Comments
 (0)