fix: variable undefined check

Ehesp · Ehesp · commit 969d174b7063 · 2023-01-09T16:43:47.000Z
diff --git a/api/src/bundler/plugins/remark-undeclared-variables.ts b/api/src/bundler/plugins/remark-undeclared-variables.ts
@@ -36,11 +36,8 @@ export default function remarkUndeclaredVariables(): (ast: Node) => void {
     }
   }
 
-  const undeclared: string[] = [];
-
   function visitorForUndeclared(node: UnDeclaredNode) {
-    if (!declared.includes(node.value)) {
-      undeclared.push(node.value);
+    if (node.value && !declared.includes(node.value)) {
       node.type = 'text';
       node.data = undefined;
       node.value = `\{${node.value}\}`;

Original file line number	Diff line number	Diff line change
`@@ -36,11 +36,8 @@ export default function remarkUndeclaredVariables(): (ast: Node) => void {`
`36`	`36`	`}`
`37`	`37`	`}`
`38`	`38`
`39`		`- const undeclared: string[] = [];`
`40`		`-`
`41`	`39`	`function visitorForUndeclared(node: UnDeclaredNode) {`
`42`		`- if (!declared.includes(node.value)) {`
`43`		`- undeclared.push(node.value);`
	`40`	`+ if (node.value && !declared.includes(node.value)) {`
`44`	`41`	`node.type = 'text';`
`45`	`42`	`node.data = undefined;`
`46`	`43`	node.value = `\{${node.value}\}`;