Skip to content

Commit 68f230f

Browse files
committed
fix(ios): copy iOS NotifeeCore library more carefully during build
there was the possibility on certain OSes (Ubuntu-22 it seems) that bash would copy into sub-directories with casual usage of paths now the copy is definitely to an absolute path and won't create erroneous nested directories regardless of initial state also it will print what it's copying, for later verification
1 parent ab9e3d0 commit 68f230f

File tree

1 file changed

+5
-7
lines changed

1 file changed

+5
-7
lines changed

build_ios_core.sh

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,12 @@ set -eo pipefail
33

44
WORKING_DIR=$(pwd)
55
POD_NAME="NotifeeCore"
6-
POD_PATH="${WORKING_DIR}/ios/${POD_NAME}/"
7-
POD_OUTPUT_FOLDER=${WORKING_DIR}/packages/react-native/ios/NotifeeCore/
6+
POD_PATH="${WORKING_DIR}/ios/${POD_NAME}"
7+
POD_OUTPUT_FOLDER_BASE=${WORKING_DIR}/packages/react-native/ios
88

9-
rm -rf "${POD_OUTPUT_FOLDER}"
10-
echo "Deleted ${POD_OUTPUT_FOLDER}"
11-
mkdir "${POD_OUTPUT_FOLDER}"
12-
echo "Created ${POD_OUTPUT_FOLDER}"
9+
rm -rf "${POD_OUTPUT_FOLDER_BASE:?}/${POD_NAME}"
10+
echo "Deleted ${POD_OUTPUT_FOLDER_BASE:?}/${POD_NAME}"
1311

1412
# - Copy the core pod
1513
echo "Moving core into packages/react-native submodule"
16-
cp -rp "${POD_PATH}" "${POD_OUTPUT_FOLDER}"
14+
cp -rvp "${POD_PATH}" "${POD_OUTPUT_FOLDER_BASE}/"

0 commit comments

Comments
 (0)