lint(app, android): lint fixes for task executor

Author: mikehardy

packages/app/android/src/main/java/io/invertase/firebase/common/TaskExecutorService.java

@@ -17,8 +17,6 @@
  *
  */
 
-import io.invertase.firebase.common.ReactNativeFirebaseJSON;
-
 import java.util.HashMap;
 import java.util.Map;
 import java.util.Set;
@@ -36,7 +34,7 @@ public class TaskExecutorService {
   private final String name;
   private final int maximumPoolSize;
   private final int keepAliveSeconds;
-  private static Map<String, ExecutorService> executors = new HashMap<>();
+  private static final Map<String, ExecutorService> executors = new HashMap<>();
 
   TaskExecutorService(String name) {
     this.name = name;
@@ -73,27 +71,25 @@ public ExecutorService getExecutor(boolean isTransactional, String identifier) {
   }
 
   private ExecutorService getNewExecutor(boolean isTransactional) {
-    if (isTransactional == true) {
+    if (isTransactional) {
       return Executors.newSingleThreadExecutor();
     } else {
-      ThreadPoolExecutor threadPoolExecutor = new ThreadPoolExecutor(0, maximumPoolSize, keepAliveSeconds, TimeUnit.SECONDS, new SynchronousQueue<Runnable>());
+      ThreadPoolExecutor threadPoolExecutor = new ThreadPoolExecutor(0, maximumPoolSize, keepAliveSeconds, TimeUnit.SECONDS, new SynchronousQueue<>());
       threadPoolExecutor.setRejectedExecutionHandler(executeInFallback);
       return threadPoolExecutor;
     }
   }
 
-  private RejectedExecutionHandler executeInFallback = new RejectedExecutionHandler() {
-    public void rejectedExecution(Runnable r, ThreadPoolExecutor executor) {
-      if (executor.isShutdown() || executor.isTerminated() || executor.isTerminating()) {
-        return;
-      }
-      ExecutorService fallbackExecutor = getTransactionalExecutor();
-      fallbackExecutor.execute(r);
-    };
+  private final RejectedExecutionHandler executeInFallback = (r, executor) -> {
+    if (executor.isShutdown() || executor.isTerminated() || executor.isTerminating()) {
+      return;
+    }
+    ExecutorService fallbackExecutor = getTransactionalExecutor();
+    fallbackExecutor.execute(r);
   };
 
   public String getExecutorName(boolean isTransactional, String identifier) {
-    if (isTransactional == true) {
+    if (isTransactional) {
       return name + "TransactionalExecutor" + identifier;
     }
     return name + "Executor" + identifier;
@@ -102,10 +98,10 @@ public String getExecutorName(boolean isTransactional, String identifier) {
   public void shutdown() {
     Set<String> existingExecutorNames = executors.keySet();
     for (String executorName : existingExecutorNames) {
-      if (executorName.startsWith(name) == false) {
+      if (!executorName.startsWith(name)) {
         existingExecutorNames.remove(executorName);
       } else {
-        removeExecutor(executorName);  
+        removeExecutor(executorName);
       }
     }
   }