fix(ios): admob shows only non-personalized ads (#5262)

dylancom · web-flow · commit 0b62d5ac9a31 · 2021-05-04T18:18:54.000-05:00
* fix: conditional was always true if requestNonPersonalizedAdsOnly contained a value
diff --git a/packages/admob/ios/RNFBAdMob/RNFBAdMobCommon.m b/packages/admob/ios/RNFBAdMob/RNFBAdMobCommon.m
@@ -49,7 +49,7 @@ + (GADRequest *)buildAdRequest:(NSDictionary *)adRequestOptions {
     GADRequest *request = [GADRequest request];
     NSMutableDictionary *extras = [@{} mutableCopy];
 
-    if (adRequestOptions[@"requestNonPersonalizedAdsOnly"]) {
+    if (adRequestOptions[@"requestNonPersonalizedAdsOnly"] && [adRequestOptions[@"requestNonPersonalizedAdsOnly"] boolValue]) {
         extras[@"npa"] = @"1";
     }
 

Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,7 @@ + (GADRequest )buildAdRequest:(NSDictionary )adRequestOptions {`
`49`	`49`	`GADRequest *request = [GADRequest request];`
`50`	`50`	`NSMutableDictionary *extras = [@{} mutableCopy];`
`51`	`51`
`52`		`- if (adRequestOptions[@"requestNonPersonalizedAdsOnly"]) {`
	`52`	`+ if (adRequestOptions[@"requestNonPersonalizedAdsOnly"] && [adRequestOptions[@"requestNonPersonalizedAdsOnly"] boolValue]) {`
`53`	`53`	`extras[@"npa"] = @"1";`
`54`	`54`	`}`
`55`	`55`