style(lint): de-lint some of the test files

- no arrow functions for describe or it
- no unused variable names unless prefixed with '_'

Author: mikehardy

tests/.jetrc.js

@@ -15,23 +15,23 @@ module.exports = {
       async before(config) {
         return config;
       },
-      async after(config) {
+      async after(_config) {
         // no-op
       },
     },
     ios: {
       async before(config) {
         return config;
       },
-      async after(config) {
+      async after(_config) {
         // no-op
       },
     },
     macos: {
       async before(config) {
         try {
           execSync(`killall "io.invertase.testing"`);
-        } catch (e) {
+        } catch (_e) {
           // noop
         }
         const macApp = spawn(
@@ -47,23 +47,26 @@ module.exports = {
           }
           if (macOsRetries < 3) {
             macOsRetries++;
+            // eslint-disable-next-line no-console
             console.log('App crashed, retrying macOS app tests...');
             this.before(config);
             return;
           } else {
+            // eslint-disable-next-line no-console
             console.error('macOS app failed to start, exiting...');
             process.exit(1);
           }
         });
         macApp.on('spawn', () => {
+          // eslint-disable-next-line no-console
           console.log('[💻] macOS app started');
         });
         return config;
       },
-      async after(config) {
+      async after(_config) {
         try {
           execSync(`killall "io.invertase.testing"`);
-        } catch (e) {
+        } catch (_e) {
           // noop
         }
       },

tests/e2e/firebase.test.js

@@ -17,10 +17,10 @@
  */
 const { execSync, spawn } = require('child_process');
 
-describe('Jet Tests', () => {
-  jest.retryTimes(3, { logErrorsBeforeRetry: true });
+describe('Jet Tests', function () {
+  jest.retryTimes(0, { logErrorsBeforeRetry: true });
 
-  it('runs all tests', async () => {
+  it('runs all tests', async function () {
     return new Promise(async (resolve, reject) => {
       const platform = detox.device.getPlatform();
       const jetProcess = spawn('yarn', ['jet', `--target=${platform}`, '--coverage'], {
@@ -81,7 +81,7 @@ afterAll(async function () {
 
   try {
     await device.terminateApp();
-  } catch (e) {
+  } catch (_) {
     // No-op
   }
 });