Skip to content

Commit 1fe6ac7

Browse files
committed
test(storage, e2e): update comments with results from new emulator
firebase-tools 10.2.2 contains an emulator with slightly different behavior See firebase/firebase-tools#3398
1 parent f7bfb9a commit 1fe6ac7

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

packages/storage/e2e/StorageReference.e2e.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -204,10 +204,10 @@ describe('storage() -> StorageReference', function () {
204204
metadata.timeCreated.should.be.a.String();
205205
metadata.contentEncoding.should.be.a.String();
206206
metadata.contentDisposition.should.be.a.String();
207-
if (device.getPlatform() === 'android') {
208-
// FIXME - iOS on emulator this is '' (empty) now ?
209-
metadata.contentType.should.equal('text/plain');
210-
}
207+
// if (device.getPlatform() === 'android') {
208+
// FIXME - on iOS and android emulator this is '' (empty) now (new in firebase-tools 10.2.2 ?
209+
// metadata.contentType.should.equal('text/plain');
210+
// }
211211
metadata.bucket.should.equal(`${firebase.app().options.projectId}.appspot.com`);
212212
metadata.metageneration.should.be.a.String();
213213
metadata.md5Hash.should.be.a.String();
@@ -383,7 +383,7 @@ describe('storage() -> StorageReference', function () {
383383
metadata.contentEncoding.should.be.a.String();
384384
metadata.contentDisposition.should.be.a.String();
385385
if (device.getPlatform() === 'android') {
386-
// FIXME on iOS this is 'application/octet-stream'?
386+
// FIXME on iOS this is '' (empty) now different in firebase-tools 10.2.2?
387387
metadata.contentType.should.equal('image/jpeg');
388388
}
389389
metadata.bucket.should.equal(`${firebase.app().options.projectId}.appspot.com`);

0 commit comments

Comments
 (0)