test(types): remove @types/jest and use jest built-in types

mikehardy · mikehardy · commit 29447aa56f78 · 2022-10-18T21:24:09.000-05:00
requires importing global symbols directly, but removes a dep
diff --git a/jest.setup.ts b/jest.setup.ts
@@ -1,4 +1,5 @@
 import * as ReactNative from 'react-native';
+import { jest } from '@jest/globals';
 
 jest.doMock('react-native', () => {
   return Object.setPrototypeOf(
diff --git a/package.json b/package.json
@@ -54,7 +54,6 @@
     "@babel/preset-env": "^7.19.4",
     "@octokit/core": "^4.1.0",
     "@tsconfig/node12": "^1.0.11",
-    "@types/jest": "28.1.2",
     "@types/react": "^17.0.48",
     "@types/react-native": "^0.67.12",
     "@typescript-eslint/eslint-plugin": "^5.40.1",
diff --git a/packages/analytics/__tests__/analytics.test.ts b/packages/analytics/__tests__/analytics.test.ts
@@ -1,3 +1,5 @@
+import { describe, expect, it, xit } from '@jest/globals';
+
 import { firebase } from '../lib';
 
 describe('Analytics', function () {
diff --git a/packages/app-check/__tests__/appcheck.test.ts b/packages/app-check/__tests__/appcheck.test.ts
@@ -1,3 +1,5 @@
+import { describe, expect, it } from '@jest/globals';
+
 import { firebase } from '../lib';
 
 describe('appCheck()', function () {
diff --git a/packages/app-distribution/__tests__/app-distribution.test.ts b/packages/app-distribution/__tests__/app-distribution.test.ts
@@ -1,3 +1,5 @@
+import { describe, expect, it } from '@jest/globals';
+
 import { firebase } from '../lib';
 
 describe('appDistribution()', function () {
diff --git a/packages/app/plugin/__tests__/androidPlugin.test.ts b/packages/app/plugin/__tests__/androidPlugin.test.ts
@@ -1,5 +1,6 @@
 import fs from 'fs/promises';
 import path from 'path';
+import { beforeAll, describe, expect, it } from '@jest/globals';
 
 import { applyPlugin } from '../src/android/applyPlugin';
 import { setBuildscriptDependency } from '../src/android/buildscriptDependency';
diff --git a/packages/app/plugin/__tests__/iosPlugin.test.ts b/packages/app/plugin/__tests__/iosPlugin.test.ts
@@ -2,6 +2,7 @@ import { IOSConfig } from '@expo/config-plugins';
 import { AppDelegateProjectFile } from '@expo/config-plugins/build/ios/Paths';
 import fs from 'fs/promises';
 import path from 'path';
+import { beforeEach, describe, expect, it, jest } from '@jest/globals';
 
 import { modifyAppDelegateAsync, modifyObjcAppDelegate } from '../src/ios/appDelegate';
 
@@ -57,7 +58,7 @@ describe('Config Plugin iOS Tests', function () {
   });
 
   it('detects Objective-C++ AppDelegate.mm', async function () {
-    jest.spyOn(fs, 'writeFile').mockImplementation();
+    jest.spyOn(fs, 'writeFile').mockImplementation(async () => {});
 
     const appDelegatePath = path.join(__dirname, './fixtures/AppDelegate_sdk45.mm');
     const appDelegateFileInfo = IOSConfig.Paths.getFileInfo(
@@ -74,7 +75,7 @@ describe('Config Plugin iOS Tests', function () {
   });
 
   it("doesn't support Swift AppDelegate", async function () {
-    jest.spyOn(fs, 'writeFile').mockImplementation();
+    jest.spyOn(fs, 'writeFile').mockImplementation(async () => {});
 
     const appDelegateFileInfo: AppDelegateProjectFile = {
       path: '.',
diff --git a/packages/auth/__tests__/auth.test.ts b/packages/auth/__tests__/auth.test.ts
@@ -1,3 +1,5 @@
+import { describe, expect, it } from '@jest/globals';
+
 import auth, { firebase } from '../lib';
 
 describe('Auth', function () {
diff --git a/packages/crashlytics/__tests__/crashlytics.test.ts b/packages/crashlytics/__tests__/crashlytics.test.ts
@@ -1,3 +1,5 @@
+import { describe, expect, it } from '@jest/globals';
+
 import { firebase } from '../lib';
 
 describe('Crashlytics', function () {
diff --git a/packages/crashlytics/plugin/__tests__/androidPlugin.test.ts b/packages/crashlytics/plugin/__tests__/androidPlugin.test.ts
@@ -1,5 +1,6 @@
 import fs from 'fs/promises';
 import path from 'path';
+import { beforeAll, describe, expect, it } from '@jest/globals';
 
 import { applyPlugin } from '../src/android/applyPlugin';
 import { setBuildscriptDependency } from '../src/android/buildscriptDependency';
diff --git a/packages/database/__tests__/database.test.ts b/packages/database/__tests__/database.test.ts
@@ -1,3 +1,5 @@
+import { describe, expect, it } from '@jest/globals';
+
 import database, { firebase } from '../lib';
 
 describe('Database', function () {
diff --git a/packages/firestore/__tests__/firestore.test.ts b/packages/firestore/__tests__/firestore.test.ts
@@ -1,3 +1,5 @@
+import { describe, expect, it } from '@jest/globals';
+
 import firestore, { firebase, FirebaseFirestoreTypes } from '../lib';
 
 const COLLECTION = 'firestore';
diff --git a/packages/functions/__tests__/functions.test.ts b/packages/functions/__tests__/functions.test.ts
@@ -1,3 +1,5 @@
+import { describe, expect, it } from '@jest/globals';
+
 import functions, { firebase } from '../lib';
 
 describe('Cloud Functions', function () {
diff --git a/packages/installations/__tests__/installations.test.ts b/packages/installations/__tests__/installations.test.ts
@@ -1,3 +1,5 @@
+import { describe, expect, it } from '@jest/globals';
+
 import { firebase } from '../lib';
 
 describe('installations()', function () {
diff --git a/packages/perf/__tests__/perf.test.ts b/packages/perf/__tests__/perf.test.ts
@@ -1,3 +1,5 @@
+import { describe, expect, it } from '@jest/globals';
+
 import perf, { firebase } from '../lib';
 
 describe('Performance Monitoring', function () {
diff --git a/packages/perf/plugin/__tests__/androidPlugin.test.ts b/packages/perf/plugin/__tests__/androidPlugin.test.ts
@@ -1,5 +1,6 @@
 import fs from 'fs/promises';
 import path from 'path';
+import { beforeAll, describe, expect, it } from '@jest/globals';
 
 import { applyPlugin } from '../src/android/applyPlugin';
 import { setBuildscriptDependency } from '../src/android/buildscriptDependency';
diff --git a/packages/remote-config/__tests__/remote-config.test.ts b/packages/remote-config/__tests__/remote-config.test.ts
@@ -14,6 +14,8 @@
  * limitations under the License.
  *
  */
+import { describe, expect, it } from '@jest/globals';
+
 import { firebase } from '../lib';
 
 describe('remoteConfig()', function () {
diff --git a/packages/storage/__tests__/storage.test.ts b/packages/storage/__tests__/storage.test.ts
@@ -1,3 +1,5 @@
+import { describe, expect, it } from '@jest/globals';
+
 import storage, { firebase } from '../lib';
 
 describe('Storage', function () {
diff --git a/yarn.lock b/yarn.lock
@@ -3545,14 +3545,6 @@
   dependencies:
     "@types/istanbul-lib-report" "*"
 
-"@types/jest@28.1.2":
-  version "28.1.2"
-  resolved "https://registry.yarnpkg.com/@types/jest/-/jest-28.1.2.tgz#c678569bb2d8e5474dd88f0851613611aeed9809"
-  integrity sha512-5dNM7mMuIrCtNJsFfvUO/5xCrG8swuT2c7ND+sl3XwlwxJf3k7e7o+PRvcFN/iIm8XhCqHqxLOj9yutDDOJoRg==
-  dependencies:
-    jest-matcher-utils "^28.0.0"
-    pretty-format "^28.0.0"
-
 "@types/json-schema@^7.0.6", "@types/json-schema@^7.0.9":
   version "7.0.11"
   resolved "https://registry.yarnpkg.com/@types/json-schema/-/json-schema-7.0.11.tgz#d421b6c527a3037f7c84433fd2c4229e016863d3"
@@ -8908,7 +8900,7 @@ jest-leak-detector@^28.1.3:
     jest-get-type "^28.0.2"
     pretty-format "^28.1.3"
 
-jest-matcher-utils@^28.0.0, jest-matcher-utils@^28.1.3:
+jest-matcher-utils@^28.1.3:
   version "28.1.3"
   resolved "https://registry.yarnpkg.com/jest-matcher-utils/-/jest-matcher-utils-28.1.3.tgz#5a77f1c129dd5ba3b4d7fc20728806c78893146e"
   integrity sha512-kQeJ7qHemKfbzKoGjHHrRKH6atgxMk8Enkk2iPQ3XwO6oE/KYD8lMYOziCkeSB9G4adPM4nR1DE8Tf5JeWH6Bw==
@@ -11816,7 +11808,7 @@ pretty-format@^26.5.2, pretty-format@^26.6.2:
     ansi-styles "^4.0.0"
     react-is "^17.0.1"
 
-pretty-format@^28.0.0, pretty-format@^28.1.3:
+pretty-format@^28.1.3:
   version "28.1.3"
   resolved "https://registry.yarnpkg.com/pretty-format/-/pretty-format-28.1.3.tgz#c9fba8cedf99ce50963a11b27d982a9ae90970d5"
   integrity sha512-8gFb/To0OmxHR9+ZTb14Df2vNxdGCX8g1xWGUTqUw5TiZvcQf5sHKObd5UcPyLLyowNwDAMTF3XWOG1B6mxl1Q==

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`import * as ReactNative from 'react-native';`
	`2`	`+import { jest } from '@jest/globals';`
`2`	`3`
`3`	`4`	`jest.doMock('react-native', () => {`
`4`	`5`	`return Object.setPrototypeOf(`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+import { describe, expect, it, xit } from '@jest/globals';`
	`2`	`+`
`1`	`3`	`import { firebase } from '../lib';`
`2`	`4`
`3`	`5`	`describe('Analytics', function () {`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+import { describe, expect, it } from '@jest/globals';`
	`2`	`+`
`1`	`3`	`import { firebase } from '../lib';`
`2`	`4`
`3`	`5`	`describe('appCheck()', function () {`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+import { describe, expect, it } from '@jest/globals';`
	`2`	`+`
`1`	`3`	`import auth, { firebase } from '../lib';`
`2`	`4`
`3`	`5`	`describe('Auth', function () {`