feat(functions): support custom domains BREAKING requires firebase-ios-sdk 7.1.0+ / firebase-android-sdk 26.2.0+ (#4950)

* feat(functions) added custom domains
* Updated test case for functions custom url
* prefers emulator to custom domain testing
* removed obsolete import

Co-authored-by: Mike Diarmid <[email protected]>

BREAKING CHANGE: minimum native SDK requirements now firebase-ios-sdk 7.1.0+ / firebase-android-sdk 26.2.0+

Author: dackers86

packages/functions/__tests__/functions.test.ts

@@ -21,6 +21,17 @@ describe('Cloud Functions', function () {
       // @ts-ignore
       expect(functions()._useFunctionsEmulatorOrigin).toBe('http://10.0.2.2');
     });
+
+    it('prefers emulator to custom domain', function () {
+      const app = firebase.app();
+      const customUrl = 'https://test.com';
+      const functions = app.functions(customUrl);
+
+      functions.useFunctionsEmulator('http://10.0.2.2');
+
+      // @ts-ignore
+      expect(functions._useFunctionsEmulatorOrigin).toBe('http://10.0.2.2');
+    });
   });
 
   describe('httpcallable()', function () {

packages/functions/e2e/functions.e2e.js

@@ -51,19 +51,37 @@ describe('functions()', function () {
       const response = await functionRunner();
       response.data.should.equal(region);
     });
-  });
 
-  it('useFunctionsEmulator', async function () {
-    const region = 'europe-west2';
-    const fnName = 'invertaseReactNativeFirebaseFunctionsEmulator';
-    const functions = firebase.app().functions(region);
+    it('accepts passing in a custom url string as first arg to an app', async function () {
+      const customUrl = 'https://us-central1-react-native-firebase-testing.cloudfunctions.net';
+      const functionsForCustomUrl = firebase.app().functions(customUrl);
+
+      functionsForCustomUrl._customUrlOrRegion.should.equal(customUrl);
+      functionsForCustomUrl.app.should.equal(firebase.app());
+      functionsForCustomUrl.app.name.should.equal(firebase.app().name);
+
+      functionsForCustomUrl.app.should.equal(firebase.app());
+
+      functionsForCustomUrl._customUrlOrRegion.should.equal(customUrl);
 
-    functions.useFunctionsEmulator('http://api.rnfirebase.io');
+      const functionRunner = functionsForCustomUrl.httpsCallable('testFunctionDefaultRegion');
 
-    const response = await functions.httpsCallable(fnName)();
+      const response = await functionRunner();
+      response.data.should.equal('null');
+    });
 
-    response.data.region.should.equal(region);
-    response.data.fnName.should.equal(fnName);
+    it('useFunctionsEmulator', async function () {
+      const region = 'europe-west2';
+      const fnName = 'invertaseReactNativeFirebaseFunctionsEmulator';
+      const functions = firebase.app().functions(region);
+
+      functions.useFunctionsEmulator('http://api.rnfirebase.io');
+
+      const response = await functions.httpsCallable(fnName)();
+
+      response.data.region.should.equal(region);
+      response.data.fnName.should.equal(fnName);
+    });
   });
 
   describe('httpsCallable(fnName)(args)', function () {

packages/functions/ios/RNFBFunctions/RNFBFunctionsModule.m

@@ -33,8 +33,8 @@ @implementation RNFBFunctionsModule
 
   RCT_EXPORT_METHOD(httpsCallable:
     (FIRApp *) firebaseApp
-        region:
-        (NSString *) region
+        customUrlOrRegion:
+        (NSString *) customUrlOrRegion
         origin:
         (NSString *) origin
         name:
@@ -48,7 +48,13 @@ @implementation RNFBFunctionsModule
         rejecter:
         (RCTPromiseRejectBlock) reject
   ) {
-    FIRFunctions *functions = [FIRFunctions functionsForApp:firebaseApp region:region];
+      
+    NSURL *url = [NSURL URLWithString:customUrlOrRegion];
+    FIRFunctions *functions = (url && url.scheme && url.host) ? [FIRFunctions functionsForApp:firebaseApp customDomain:customUrlOrRegion] : [FIRFunctions functionsForApp:firebaseApp region:customUrlOrRegion];
+      
+      
+
+      
 
     if (origin != nil) {
       [functions useFunctionsEmulatorOrigin:origin];

packages/functions/lib/index.d.ts

@@ -390,7 +390,7 @@ declare module '@react-native-firebase/app' {
       >;
     }
     interface FirebaseApp {
-      functions(region?: string): FirebaseFunctionsTypes.Module;
+      functions(customUrlOrRegion?: string): FirebaseFunctionsTypes.Module;
     }
   }
 }