Skip to content

Commit 39e0444

Browse files
committed
fix(android): specify that android services are not exported
Additionally, app is directBootAware - this mirrors upstream definition: https://github.com/firebase/firebase-android-sdk/blob/ad135d8c3c1243b4c673e17bc032ee1052fb2a22/firebase-common/src/main/AndroidManifest.xml#L10-L12
1 parent 3cb1d0a commit 39e0444

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed

packages/app/android/src/main/AndroidManifest.xml

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,16 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
3+
xmlns:tools="http://schemas.android.com/tools"
34
package="io.invertase.firebase">
45

56
<application>
67
<meta-data android:name="app_data_collection_default_enabled" android:value="${firebaseJsonDataCollectionDefaultEnabled}"/>
7-
<service android:name="com.google.firebase.components.ComponentDiscoveryService">
8+
<service
9+
android:name="com.google.firebase.components.ComponentDiscoveryService"
10+
android:directBootAware="true"
11+
android:exported="false"
12+
tools:targetApi="n"
13+
>
814
<meta-data
915
android:name="com.google.firebase.components:io.invertase.firebase.app.ReactNativeFirebaseAppRegistrar"
1016
android:value="com.google.firebase.components.ComponentRegistrar" />

packages/messaging/android/src/main/AndroidManifest.xml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,8 @@
77
<uses-permission android:name="android.permission.ACCESS_NETWORK_STATE"/>
88

99
<application>
10-
<service android:name=".ReactNativeFirebaseMessagingHeadlessService" />
10+
<service android:name=".ReactNativeFirebaseMessagingHeadlessService"
11+
android:exported="false" />
1112
<service android:name=".ReactNativeFirebaseMessagingService"
1213
android:exported="false">
1314
<intent-filter>

0 commit comments

Comments
 (0)