Skip to content

Commit 3fef777

Browse files
committed
fix(auth, android): remove browser dependency, upstream includes now
Previous versions of firebase-android-sdk did not express their dependency on androidx.browser library but used it for reCAPTHCA flow, leading to crashes. We had to temporarily add a dependency here/downstream to work around. Upstream has the dependency now, verified via `./gradlew :app:dependencies` Fixes #4744
1 parent 0524540 commit 3fef777

File tree

1 file changed

+0
-11
lines changed

1 file changed

+0
-11
lines changed

packages/auth/android/build.gradle

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -81,21 +81,10 @@ repositories {
8181
mavenCentral()
8282
}
8383

84-
def safeExtGet(prop, fallback) {
85-
rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback
86-
}
87-
88-
def BROWSER_VERSION = safeExtGet('androidxBrowserVersion', '[1.0.0, 2.0.0)')
89-
9084
dependencies {
9185
api appProject
9286
implementation platform("com.google.firebase:firebase-bom:${ReactNative.ext.getVersion("firebase", "bom")}")
9387
implementation "com.google.firebase:firebase-auth"
94-
95-
// This is needed for the reCAPTCHA flow but is incorrectly missing as a transitive dependency upstream
96-
// https://github.com/invertase/react-native-firebase/issues/4744
97-
// https://github.com/firebase/firebase-android-sdk/issues/2164
98-
implementation "androidx.browser:browser:${BROWSER_VERSION}"
9988
}
10089

10190
ReactNative.shared.applyPackageVersion()

0 commit comments

Comments
 (0)