test(lint): yarn lint:android will now exit correctly every time

so workaround to exit during CI workflow not needed, also added
prescriptive messages to the output of running it

Author: mikehardy

.github/workflows/linting.yml

@@ -50,7 +50,7 @@ jobs:
           timeout_minutes: 3
           retry_wait_seconds: 10
           max_attempts: 3
-          command: yarn lint && git diff --exit-code
+          command: yarn lint
       - uses: actions/cache/save@v4
         name: Yarn Cache Save
         if: "${{ github.ref == 'refs/heads/main' }}"

package.json

@@ -10,7 +10,7 @@
     "build:all:build": "lerna run build",
     "lint": "yarn lint:js && yarn lint:android && yarn lint:ios:check",
     "lint:js": "eslint packages/* --max-warnings=0",
-    "lint:android": "google-java-format --set-exit-if-changed --replace --glob=\"packages/*/android/src/**/*.java\"",
+    "lint:android": "(google-java-format --set-exit-if-changed --replace --glob=\"packages/*/android/src/**/*.java\" || (echo \"\n\nandroid formatting error - please re-run\n\n\" && exit 1)) && (git diff --exit-code packages/*/android/src || (echo \"\n\nandroid files changed from linting, please examine and commit result\n\n\" && exit 1))",
     "lint:ios:check": "clang-format --glob=\"packages/*/ios/**/*.{h,cpp,m,mm}\" --style=Google -n -Werror",
     "lint:ios:fix": "clang-format -i --glob=\"packages/*/ios/**/*.{h,cpp,m,mm}\" --style=Google",
     "lint:markdown": "prettier --check \"docs/**/*.md\"",