test: fix remaining e2e modular deprecation warnings

mikehardy · mikehardy · commit 4ce3e03c695e · 2025-04-30T10:49:14.000-05:00
mechanical fixes grouped together for all the smaller-line-count packages
diff --git a/packages/app-distribution/e2e/app-distribution.e2e.js b/packages/app-distribution/e2e/app-distribution.e2e.js
@@ -17,6 +17,16 @@
 
 describe('appDistribution()', function () {
   describe('v8 compatibility', function () {
+    beforeEach(async function beforeEachTest() {
+      // @ts-ignore
+      globalThis.RNFB_SILENCE_MODULAR_DEPRECATION_WARNINGS = true;
+    });
+
+    afterEach(async function afterEachTest() {
+      // @ts-ignore
+      globalThis.RNFB_SILENCE_MODULAR_DEPRECATION_WARNINGS = false;
+    });
+
     describe('native module is loaded', function () {
       it('checks native module load status', function () {
         firebase.appDistribution().native;
diff --git a/packages/dynamic-links/e2e/builder.analytics.e2e.js b/packages/dynamic-links/e2e/builder.analytics.e2e.js
@@ -19,6 +19,16 @@ const { baseParams } = require('./dynamicLinks.e2e');
 
 describe('dynamicLinks() dynamicLinkParams.analytics', function () {
   describe('v8 compatibility', function () {
+    beforeEach(async function beforeEachTest() {
+      // @ts-ignore
+      globalThis.RNFB_SILENCE_MODULAR_DEPRECATION_WARNINGS = true;
+    });
+
+    afterEach(async function afterEachTest() {
+      // @ts-ignore
+      globalThis.RNFB_SILENCE_MODULAR_DEPRECATION_WARNINGS = false;
+    });
+
     it('throws if analytics is not an object', function () {
       try {
         firebase.dynamicLinks().buildLink({
diff --git a/packages/dynamic-links/e2e/builder.android.e2e.js b/packages/dynamic-links/e2e/builder.android.e2e.js
@@ -19,6 +19,16 @@ const { baseParams } = require('./dynamicLinks.e2e');
 
 describe('dynamicLinks() dynamicLinkParams.android', function () {
   describe('v8 compatibility', function () {
+    beforeEach(async function beforeEachTest() {
+      // @ts-ignore
+      globalThis.RNFB_SILENCE_MODULAR_DEPRECATION_WARNINGS = true;
+    });
+
+    afterEach(async function afterEachTest() {
+      // @ts-ignore
+      globalThis.RNFB_SILENCE_MODULAR_DEPRECATION_WARNINGS = false;
+    });
+
     it('throws if android is not an object', function () {
       try {
         firebase.dynamicLinks().buildLink({
diff --git a/packages/dynamic-links/e2e/builder.e2e.js b/packages/dynamic-links/e2e/builder.e2e.js
@@ -17,6 +17,16 @@
 
 describe('dynamicLinks() dynamicLinkParams', function () {
   describe('v8 compatibility', function () {
+    beforeEach(async function beforeEachTest() {
+      // @ts-ignore
+      globalThis.RNFB_SILENCE_MODULAR_DEPRECATION_WARNINGS = true;
+    });
+
+    afterEach(async function afterEachTest() {
+      // @ts-ignore
+      globalThis.RNFB_SILENCE_MODULAR_DEPRECATION_WARNINGS = false;
+    });
+
     it('throws if params are not an object', function () {
       try {
         firebase.dynamicLinks().buildLink(123);
diff --git a/packages/dynamic-links/e2e/builder.ios.e2e.js b/packages/dynamic-links/e2e/builder.ios.e2e.js
@@ -19,6 +19,16 @@ const { baseParams } = require('./dynamicLinks.e2e');
 
 describe('dynamicLinks() dynamicLinkParams.ios', function () {
   describe('v8 compatibility', function () {
+    beforeEach(async function beforeEachTest() {
+      // @ts-ignore
+      globalThis.RNFB_SILENCE_MODULAR_DEPRECATION_WARNINGS = true;
+    });
+
+    afterEach(async function afterEachTest() {
+      // @ts-ignore
+      globalThis.RNFB_SILENCE_MODULAR_DEPRECATION_WARNINGS = false;
+    });
+
     it('throws if ios is not an object', function () {
       try {
         firebase.dynamicLinks().buildLink({
diff --git a/packages/dynamic-links/e2e/builder.itunes.e2e.js b/packages/dynamic-links/e2e/builder.itunes.e2e.js
@@ -19,6 +19,16 @@ const { baseParams } = require('./dynamicLinks.e2e');
 
 describe('dynamicLinks() dynamicLinkParams.itunes', function () {
   describe('v8 compatibility', function () {
+    beforeEach(async function beforeEachTest() {
+      // @ts-ignore
+      globalThis.RNFB_SILENCE_MODULAR_DEPRECATION_WARNINGS = true;
+    });
+
+    afterEach(async function afterEachTest() {
+      // @ts-ignore
+      globalThis.RNFB_SILENCE_MODULAR_DEPRECATION_WARNINGS = false;
+    });
+
     it('throws if itunes is not an object', function () {
       try {
         firebase.dynamicLinks().buildLink({
diff --git a/packages/dynamic-links/e2e/builder.navigation.e2e.js b/packages/dynamic-links/e2e/builder.navigation.e2e.js
@@ -19,6 +19,16 @@ const { baseParams } = require('./dynamicLinks.e2e');
 
 describe('dynamicLinks() dynamicLinkParams.navigation', function () {
   describe('v8 compatibility', function () {
+    beforeEach(async function beforeEachTest() {
+      // @ts-ignore
+      globalThis.RNFB_SILENCE_MODULAR_DEPRECATION_WARNINGS = true;
+    });
+
+    afterEach(async function afterEachTest() {
+      // @ts-ignore
+      globalThis.RNFB_SILENCE_MODULAR_DEPRECATION_WARNINGS = false;
+    });
+
     it('throws if navigation is not an object', function () {
       try {
         firebase.dynamicLinks().buildLink({
diff --git a/packages/dynamic-links/e2e/builder.otherplatform.e2e.js b/packages/dynamic-links/e2e/builder.otherplatform.e2e.js
@@ -2,6 +2,16 @@ const { baseParams } = require('./dynamicLinks.e2e');
 
 describe('dynamicLinks() dynamicLinkParams.otherPlatform', function () {
   describe('v8 compatibility', function () {
+    beforeEach(async function beforeEachTest() {
+      // @ts-ignore
+      globalThis.RNFB_SILENCE_MODULAR_DEPRECATION_WARNINGS = true;
+    });
+
+    afterEach(async function afterEachTest() {
+      // @ts-ignore
+      globalThis.RNFB_SILENCE_MODULAR_DEPRECATION_WARNINGS = false;
+    });
+
     it('throws if otherPlatform is not an object', function () {
       try {
         firebase.dynamicLinks().buildLink({
diff --git a/packages/dynamic-links/e2e/builder.social.e2e.js b/packages/dynamic-links/e2e/builder.social.e2e.js
@@ -19,6 +19,16 @@ const { baseParams } = require('./dynamicLinks.e2e');
 
 describe('dynamicLinks() dynamicLinkParams.social', function () {
   describe('v8 compatibility', function () {
+    beforeEach(async function beforeEachTest() {
+      // @ts-ignore
+      globalThis.RNFB_SILENCE_MODULAR_DEPRECATION_WARNINGS = true;
+    });
+
+    afterEach(async function afterEachTest() {
+      // @ts-ignore
+      globalThis.RNFB_SILENCE_MODULAR_DEPRECATION_WARNINGS = false;
+    });
+
     it('throws if social is not an object', function () {
       try {
         firebase.dynamicLinks().buildLink({
diff --git a/packages/dynamic-links/e2e/dynamicLinks.e2e.js b/packages/dynamic-links/e2e/dynamicLinks.e2e.js
@@ -61,6 +61,16 @@ module.exports.baseParams = baseParams;
 
 describe('dynamicLinks()', function () {
   describe('v8 compatibility', function () {
+    beforeEach(async function beforeEachTest() {
+      // @ts-ignore
+      globalThis.RNFB_SILENCE_MODULAR_DEPRECATION_WARNINGS = true;
+    });
+
+    afterEach(async function afterEachTest() {
+      // @ts-ignore
+      globalThis.RNFB_SILENCE_MODULAR_DEPRECATION_WARNINGS = false;
+    });
+
     describe('namespace', function () {
       it('accessible from firebase.app()', function () {
         const app = firebase.app();
diff --git a/packages/installations/e2e/installations.e2e.js b/packages/installations/e2e/installations.e2e.js
@@ -62,6 +62,16 @@ const PROJECT_ID = 448618578101; // this is "magic", it's the react-native-fireb
 
 describe('installations() modular', function () {
   describe('firebase v8 compatibility', function () {
+    beforeEach(async function beforeEachTest() {
+      // @ts-ignore
+      globalThis.RNFB_SILENCE_MODULAR_DEPRECATION_WARNINGS = true;
+    });
+
+    afterEach(async function afterEachTest() {
+      // @ts-ignore
+      globalThis.RNFB_SILENCE_MODULAR_DEPRECATION_WARNINGS = false;
+    });
+
     describe('getId()', function () {
       it('returns a valid installation id', async function () {
         const id = await firebase.installations().getId();
diff --git a/packages/ml/e2e/ml.e2e.js b/packages/ml/e2e/ml.e2e.js
@@ -17,6 +17,16 @@
 
 describe('ml()', function () {
   describe('v8 compatibility', function () {
+    beforeEach(async function beforeEachTest() {
+      // @ts-ignore
+      globalThis.RNFB_SILENCE_MODULAR_DEPRECATION_WARNINGS = true;
+    });
+
+    afterEach(async function afterEachTest() {
+      // @ts-ignore
+      globalThis.RNFB_SILENCE_MODULAR_DEPRECATION_WARNINGS = false;
+    });
+
     describe('namespace', function () {
       it('accessible from firebase.app()', function () {
         const app = firebase.app();
@@ -38,9 +48,10 @@ describe('ml()', function () {
 
   describe('modular', function () {
     it('supports multiple apps', function () {
+      const { getApp } = modular;
       const { getML } = mlModular;
       const ml = getML();
-      const secondaryML = getML(firebase.app('secondaryFromNative'));
+      const secondaryML = getML(getApp('secondaryFromNative'));
 
       ml.app.name.should.equal('[DEFAULT]');
 
diff --git a/packages/ml/lib/modular/index.js b/packages/ml/lib/modular/index.js
@@ -11,7 +11,7 @@ import { getApp } from '@react-native-firebase/app';
  */
 export function getML(app) {
   if (app) {
-    return getApp(app).ml();
+    return getApp(app.name).ml();
   }
   return getApp().ml();
 }
