Skip to content

Commit 595256e

Browse files
committed
lint(e2e): fix duplicate test title lint errors
1 parent 465323d commit 595256e

File tree

5 files changed

+13
-27
lines changed

5 files changed

+13
-27
lines changed

packages/analytics/e2e/analytics.e2e.js

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -30,14 +30,6 @@ describe('analytics()', function() {
3030
string: 'string',
3131
});
3232
});
33-
34-
it('log an event with parameters', async function() {
35-
await firebase.analytics().logEvent('invertase_event', {
36-
boolean: true,
37-
number: 1,
38-
string: 'string',
39-
});
40-
});
4133
});
4234

4335
describe('setAnalyticsCollectionEnabled()', function() {

packages/firestore/e2e/GeoPoint.e2e.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ describe('firestore.GeoPoint', function() {
4040
}
4141
});
4242

43-
it('throws if latitude is not a number', function() {
43+
it('throws if longitude is not a number', function() {
4444
try {
4545
new firebase.firestore.GeoPoint(0, '123');
4646
return Promise.reject(new Error('Did not throw an Error.'));

packages/messaging/e2e/messaging.e2e.js

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -74,12 +74,6 @@ describe('messaging()', function() {
7474
});
7575
});
7676

77-
describe('unregisterDeviceForRemoteMessages', function() {
78-
android.it('resolves on android', async () => {
79-
await firebase.messaging().unregisterDeviceForRemoteMessages();
80-
});
81-
});
82-
8377
describe('requestPermission', function() {
8478
android.it('resolves 1 on android', async () => {
8579
should.equal(await firebase.messaging().requestPermission(), 1);

packages/messaging/e2e/remoteMessage.e2e.js

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ describe('messaging().sendMessage(*)', function() {
4747
});
4848

4949
android.describe('to', () => {
50-
it('throws if not a string', function() {
50+
it('throws if to is not a string', function() {
5151
try {
5252
firebase.messaging().sendMessage({
5353
to: 123,
@@ -59,15 +59,15 @@ describe('messaging().sendMessage(*)', function() {
5959
}
6060
});
6161

62-
it('accepts custom value', async function() {
62+
it('accepts custom to value', async function() {
6363
await firebase.messaging().sendMessage({
6464
to: 'foobar',
6565
});
6666
});
6767
});
6868

6969
android.describe('messageId', () => {
70-
it('throws if not a string', function() {
70+
it('throws if messageId is not a string', function() {
7171
try {
7272
firebase.messaging().sendMessage({
7373
messageId: 123,
@@ -79,7 +79,7 @@ describe('messaging().sendMessage(*)', function() {
7979
}
8080
});
8181

82-
it('accepts custom value', async function() {
82+
it('accepts custom messageId value', async function() {
8383
await firebase.messaging().sendMessage({
8484
messageId: 'foobar',
8585
});
@@ -123,15 +123,15 @@ describe('messaging().sendMessage(*)', function() {
123123
}
124124
});
125125

126-
it('accepts custom value', async function() {
126+
it('accepts custom ttl value', async function() {
127127
await firebase.messaging().sendMessage({
128128
ttl: 123,
129129
});
130130
});
131131
});
132132

133133
android.describe('data', () => {
134-
it('throws if not an object', function() {
134+
it('throws if data not an object', function() {
135135
try {
136136
firebase.messaging().sendMessage({
137137
data: 123,
@@ -143,7 +143,7 @@ describe('messaging().sendMessage(*)', function() {
143143
}
144144
});
145145

146-
it('accepts custom value', async function() {
146+
it('accepts custom data value', async function() {
147147
await firebase.messaging().sendMessage({
148148
data: {
149149
foo: 'bar',
@@ -153,7 +153,7 @@ describe('messaging().sendMessage(*)', function() {
153153
});
154154

155155
android.describe('collapseKey', () => {
156-
it('throws if not a string', function() {
156+
it('throws if collapseKey is not a string', function() {
157157
try {
158158
firebase.messaging().sendMessage({
159159
collapseKey: 123,
@@ -165,15 +165,15 @@ describe('messaging().sendMessage(*)', function() {
165165
}
166166
});
167167

168-
it('accepts custom value', async function() {
168+
it('accepts custom collapseKey value', async function() {
169169
await firebase.messaging().sendMessage({
170170
collapseKey: 'foobar',
171171
});
172172
});
173173
});
174174

175175
android.describe('messageType', () => {
176-
it('throws if not a string', function() {
176+
it('throws if messageType is not a string', function() {
177177
try {
178178
firebase.messaging().sendMessage({
179179
messageType: 123,
@@ -185,7 +185,7 @@ describe('messaging().sendMessage(*)', function() {
185185
}
186186
});
187187

188-
it('accepts custom value', async function() {
188+
it('accepts custom messageType value', async function() {
189189
await firebase.messaging().sendMessage({
190190
messageType: 'foobar',
191191
});

packages/remote-config/e2e/config.e2e.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@ describe('remoteConfig()', function() {
174174
});
175175
});
176176

177-
describe('getAll()', function() {
177+
describe('getAll() with remote', function() {
178178
it('should return an object of all available values', function() {
179179
const config = firebase.remoteConfig().getAll();
180180
config.number.asNumber().should.equal(1337);

0 commit comments

Comments
 (0)