Skip to content

Commit 5a71ad7

Browse files
authored
fix(admob): improve defense logic to prevent multiple calls (#4849)
1 parent 129dc6a commit 5a71ad7

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

packages/admob/lib/ads/InterstitialAd.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,11 +45,11 @@ export default class InterstitialAd extends MobileAd {
4545

4646
load() {
4747
// Prevent multiple load calls
48-
if (this._loaded) {
48+
if (this._loaded || this._isLoadCalled) {
4949
return;
5050
}
5151

52-
this._loaded = true;
52+
this._isLoadCalled = true;
5353
this._admob.native.interstitialLoad(this._requestId, this._adUnitId, this._requestOptions);
5454
}
5555

packages/admob/lib/ads/MobileAd.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ export default class MobileAd {
2828
this._requestOptions = requestOptions;
2929

3030
this._loaded = false;
31+
this._isLoadCalled = false;
3132
this._onAdEventHandler = null;
3233

3334
this._nativeListener = admob.emitter.addListener(
@@ -45,6 +46,7 @@ export default class MobileAd {
4546

4647
if (type === AdEventType.CLOSED || type === RewardedAdEventType.CLOSED) {
4748
this._loaded = false;
49+
this._isLoadCalled = false;
4850
}
4951

5052
if (this._onAdEventHandler) {

packages/admob/lib/ads/RewardedAd.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,11 +45,11 @@ export default class RewardedAd extends MobileAd {
4545

4646
load() {
4747
// Prevent multiple load calls
48-
if (this._loaded) {
48+
if (this._loaded || this._isLoadCalled) {
4949
return;
5050
}
5151

52-
this._loaded = true;
52+
this._isLoadCalled = true;
5353
this._admob.native.rewardedLoad(this._requestId, this._adUnitId, this._requestOptions);
5454
}
5555

0 commit comments

Comments
 (0)