Skip to content

Commit 66103ff

Browse files
JiriHoffmannmikehardy
authored andcommitted
feat(firestore): implement withConverter
1 parent c4959a1 commit 66103ff

19 files changed

+2651
-145
lines changed

packages/firestore/__tests__/firestore.test.ts

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -946,6 +946,7 @@ describe('Firestore', function () {
946946

947947
collectionRefV9Deprecation(
948948
() => getCountFromServer(query),
949+
// @ts-expect-error Combines modular and namespace imports
949950
() => query.count(),
950951
'count',
951952
);
@@ -958,6 +959,7 @@ describe('Firestore', function () {
958959

959960
collectionRefV9Deprecation(
960961
() => getCountFromServer(query),
962+
// @ts-expect-error Combines modular and namespace API
961963
() => query.countFromServer(),
962964
'countFromServer',
963965
);
@@ -970,6 +972,7 @@ describe('Firestore', function () {
970972

971973
collectionRefV9Deprecation(
972974
() => endAt('foo'),
975+
// @ts-expect-error Combines modular and namespace API
973976
() => query.endAt('foo'),
974977
'endAt',
975978
);
@@ -982,6 +985,7 @@ describe('Firestore', function () {
982985

983986
collectionRefV9Deprecation(
984987
() => endBefore('foo'),
988+
// @ts-expect-error Combines modular and namespace API
985989
() => query.endBefore('foo'),
986990
'endBefore',
987991
);
@@ -994,6 +998,7 @@ describe('Firestore', function () {
994998

995999
collectionRefV9Deprecation(
9961000
() => getDocs(query),
1001+
// @ts-expect-error Combines modular and namespace API
9971002
() => query.get(),
9981003
'get',
9991004
);
@@ -1007,6 +1012,7 @@ describe('Firestore', function () {
10071012
collectionRefV9Deprecation(
10081013
// no equivalent method
10091014
() => {},
1015+
// @ts-expect-error Combines modular and namespace API
10101016
() => query.isEqual(query),
10111017
'isEqual',
10121018
);
@@ -1019,6 +1025,7 @@ describe('Firestore', function () {
10191025

10201026
collectionRefV9Deprecation(
10211027
() => limit(9),
1028+
// @ts-expect-error Combines modular and namespace API
10221029
() => query.limit(9),
10231030
'limit',
10241031
);
@@ -1031,6 +1038,7 @@ describe('Firestore', function () {
10311038

10321039
collectionRefV9Deprecation(
10331040
() => limitToLast(9),
1041+
// @ts-expect-error Combines modular and namespace API
10341042
() => query.limitToLast(9),
10351043
'limitToLast',
10361044
);
@@ -1043,6 +1051,7 @@ describe('Firestore', function () {
10431051

10441052
collectionRefV9Deprecation(
10451053
() => onSnapshot(query, () => {}),
1054+
// @ts-expect-error Combines modular and namespace API
10461055
() => query.onSnapshot(() => {}),
10471056
'onSnapshot',
10481057
);
@@ -1055,6 +1064,7 @@ describe('Firestore', function () {
10551064

10561065
collectionRefV9Deprecation(
10571066
() => orderBy('foo', 'asc'),
1067+
// @ts-expect-error Combines modular and namespace API
10581068
() => query.orderBy('foo', 'asc'),
10591069
'orderBy',
10601070
);
@@ -1067,6 +1077,7 @@ describe('Firestore', function () {
10671077

10681078
collectionRefV9Deprecation(
10691079
() => startAfter('foo'),
1080+
// @ts-expect-error Combines modular and namespace API
10701081
() => query.startAfter('foo'),
10711082
'startAfter',
10721083
);
@@ -1079,6 +1090,7 @@ describe('Firestore', function () {
10791090

10801091
collectionRefV9Deprecation(
10811092
() => startAt('foo'),
1093+
// @ts-expect-error Combines modular and namespace API
10821094
() => query.startAt('foo'),
10831095
'startAt',
10841096
);
@@ -1091,6 +1103,7 @@ describe('Firestore', function () {
10911103

10921104
collectionRefV9Deprecation(
10931105
() => where('foo', '==', 'bar'),
1106+
// @ts-expect-error Combines modular and namespace API
10941107
() => query.where('foo', '==', 'bar'),
10951108
'where',
10961109
);
@@ -1103,6 +1116,7 @@ describe('Firestore', function () {
11031116

11041117
collectionRefV9Deprecation(
11051118
() => addDoc(query, { foo: 'bar' }),
1119+
// @ts-expect-error Combines modular and namespace API
11061120
() => query.add({ foo: 'bar' }),
11071121
'add',
11081122
);
@@ -1115,6 +1129,7 @@ describe('Firestore', function () {
11151129

11161130
collectionRefV9Deprecation(
11171131
() => doc(query, 'bar'),
1132+
// @ts-expect-error Combines modular and namespace API
11181133
() => query.doc('foo'),
11191134
'doc',
11201135
);
@@ -1140,6 +1155,7 @@ describe('Firestore', function () {
11401155
const docRef = firestore.doc('some/foo');
11411156

11421157
docRefV9Deprecation(
1158+
// @ts-expect-error Combines modular and namespace imports
11431159
() => deleteDoc(docRef),
11441160
() => docRef.delete(),
11451161
'delete',
@@ -1152,6 +1168,7 @@ describe('Firestore', function () {
11521168
const docRef = firestore.doc('some/foo');
11531169

11541170
docRefV9Deprecation(
1171+
// @ts-expect-error Combines modular and namespace imports
11551172
() => getDoc(docRef),
11561173
() => docRef.get(),
11571174
'get',
@@ -1177,6 +1194,7 @@ describe('Firestore', function () {
11771194
const docRef = firestore.doc('some/foo');
11781195

11791196
docRefV9Deprecation(
1197+
// @ts-expect-error Combines modular and namespace imports
11801198
() => onSnapshot(docRef, () => {}),
11811199
() => docRef.onSnapshot(() => {}),
11821200
'onSnapshot',
@@ -1189,6 +1207,7 @@ describe('Firestore', function () {
11891207
const docRef = firestore.doc('some/foo');
11901208

11911209
docRefV9Deprecation(
1210+
// @ts-expect-error Combines modular and namespace imports
11921211
() => setDoc(docRef, { foo: 'bar' }),
11931212
() => docRef.set({ foo: 'bar' }),
11941213
'set',
@@ -1201,6 +1220,7 @@ describe('Firestore', function () {
12011220
const docRef = firestore.doc('some/foo');
12021221

12031222
docRefV9Deprecation(
1223+
// @ts-expect-error Combines modular and namespace imports
12041224
() => updateDoc(docRef, { foo: 'bar' }),
12051225
() => docRef.update({ foo: 'bar' }),
12061226
'update',

0 commit comments

Comments
 (0)