build(e2e, ios): integrate xcbeautify, with correct compile failure status report

the current xcode build is still very noisy

previously there was an issue with combination of xcpretty and CI, such that
compile failures were not detected and failing CI.

xcpretty is abandoned but xcbeautify lives. The built-in `-quiet` is too quiet.

I believe this combo of set -o pipefail and xcbeautify should do it.
It passes local negative- and positive-testing on build status reporting

Author: mikehardy

.github/workflows/tests_e2e_ios.yml

@@ -120,6 +120,14 @@ jobs:
       - name: Start Firestore Emulator
         run: yarn tests:emulator:start-ci
 
+      - name: Install brew utilities
+        uses: nick-invision/retry@v2
+        with:
+          timeout_minutes: 5
+          retry_wait_seconds: 60
+          max_attempts: 3
+          command: HOMEBREW_NO_AUTO_UPDATE=1 brew tap wix/brew && HOMEBREW_NO_AUTO_UPDATE=1 brew install applesimutils xcbeautify && applesimutils --list
+
       - name: Build iOS App
         run: |
           export PATH="/usr/lib/ccache:/usr/local/opt/ccache/libexec:$PATH"
@@ -135,14 +143,6 @@ jobs:
           ccache -s
         shell: bash
 
-      - name: Install applesimutils
-        uses: nick-invision/retry@v2
-        with:
-          timeout_minutes: 5
-          retry_wait_seconds: 60
-          max_attempts: 3
-          command: HOMEBREW_NO_AUTO_UPDATE=1 brew tap wix/brew && HOMEBREW_NO_AUTO_UPDATE=1 brew install applesimutils && applesimutils --list
-
       - name: Metro Bundler Cache
         uses: actions/cache@v2
         with:

CONTRIBUTING.md

@@ -101,6 +101,8 @@ cd react-native-firebase
 ```bash
 yarn
 yarn tests:ios:pod:install
+brew tap wix/brew
+brew install applesimutils xbeautify
 ```
 
 > Note that this project is a mono-repo, so you only need to install NPM dependencies once at the root of the project with `yarn`.

tests/package.json

@@ -58,15 +58,15 @@
     "configurations": {
       "ios.sim.debug": {
         "binaryPath": "ios/build/Build/Products/Debug-iphonesimulator/testing.app",
-        "build": "xcodebuild VALID_ARCHS=\"`uname -m`\"  CC=clang CPLUSPLUS=clang++ LD=clang LDPLUSPLUS=clang++ -workspace ios/testing.xcworkspace -scheme testing -configuration Debug -sdk iphonesimulator -derivedDataPath ios/build",
+        "build": "set -o pipefail && xcodebuild VALID_ARCHS=\"`uname -m`\"  CC=clang CPLUSPLUS=clang++ LD=clang LDPLUSPLUS=clang++ -workspace ios/testing.xcworkspace -scheme testing -configuration Debug -sdk iphonesimulator -derivedDataPath ios/build | xcbeautify",
         "type": "ios.simulator",
         "device": {
           "type": "iPhone 11"
         }
       },
       "ios.sim.release": {
         "binaryPath": "ios/build/Build/Products/Release-iphonesimulator/testing.app",
-        "build": "export RCT_NO_LAUNCH_PACKAGER=true && xcodebuild  CC=clang CPLUSPLUS=clang++ LD=clang LDPLUSPLUS=clang++ -workspace ios/testing.xcworkspace -scheme testing -configuration Release -sdk iphonesimulator -derivedDataPath ios/build",
+        "build": "export RCT_NO_LAUNCH_PACKAGER=true && set -o pipefail | xcodebuild  CC=clang CPLUSPLUS=clang++ LD=clang LDPLUSPLUS=clang++ -workspace ios/testing.xcworkspace -scheme testing -configuration Release -sdk iphonesimulator -derivedDataPath ios/build | xcbeautify",
         "type": "ios.simulator",
         "device": {
           "type": "iPhone 11"