Skip to content

Commit 776b97a

Browse files
committed
test(e2e): bump dependencies, use macos-11 but Xcode 12.5.1 for iOS
Until Detox supports iOS 15, we'll use macos-11 runner but we need to pin Xcode to 12.5.1 so we get iOS 14 simulators for e2e tests Cleanup from Detox update - should be merged with it This just removes the os 13.7 designator for the detox config that was going to be unworkable in practice, I'm pinning iOS builds on Xcode 12.5.1 for now for Detox (though I build work projects with 13)
1 parent b3c81e1 commit 776b97a

File tree

5 files changed

+10
-11
lines changed

5 files changed

+10
-11
lines changed

.github/workflows/pr_title.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,6 @@ jobs:
1212
env:
1313
GITHUB_TOKEN: ${{ secrets.GH_TOKEN }}
1414
steps:
15-
- uses: amannn/[email protected].0
15+
- uses: amannn/[email protected].2
1616
with:
1717
validateSingleCommit: true

.github/workflows/publish.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ jobs:
1818
ref: 'master'
1919
fetch-depth: 0
2020
- name: Yarn Install
21-
uses: nick-invision/retry@v1
21+
uses: nick-invision/retry@v2
2222
with:
2323
timeout_minutes: 10
2424
retry_wait_seconds: 60
@@ -29,7 +29,7 @@ jobs:
2929
git config --global user.name '@Salakar'
3030
git config --global user.email '[email protected]'
3131
git remote set-url origin [email protected]:$GITHUB_REPOSITORY
32-
- uses: webfactory/ssh-agent@v0.4.1
32+
- uses: webfactory/ssh-agent@v0.5.3
3333
with:
3434
ssh-private-key: ${{ secrets.SSH_PRIVATE_KEY }}
3535
- name: Publish Packages

.github/workflows/tests_e2e_android.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ on:
2222
jobs:
2323
android:
2424
name: Android
25-
runs-on: macos-latest
25+
runs-on: macos-11
2626
timeout-minutes: 70
2727
env:
2828
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
@@ -40,13 +40,13 @@ jobs:
4040
# Set up tool versions
4141
- uses: actions/setup-node@v2
4242
with:
43-
node-version: '14'
43+
node-version: 14
4444

4545
- name: Configure JDK 1.11
4646
uses: actions/setup-java@v2
4747
with:
4848
distribution: 'adopt'
49-
java-version: '11' # ubuntu-latest is about to default to 11, force it everywhere
49+
java-version: '11'
5050

5151
# Set path variables needed for caches
5252
- name: Set workflow variables

.github/workflows/tests_e2e_ios.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@ on:
2222
jobs:
2323
ios:
2424
name: iOS
25-
runs-on: macos-latest
26-
# TODO matrix across APIs, at least 10 and 13 (lowest to highest)
25+
runs-on: macos-11
26+
# TODO matrix across APIs, at least 11 and 15 (lowest to highest)
2727
timeout-minutes: 60
2828
env:
2929
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
@@ -39,7 +39,7 @@ jobs:
3939

4040
- uses: maxim-lobanov/setup-xcode@v1
4141
with:
42-
xcode-version: latest-stable
42+
xcode-version: '12.5.1' # Use 12.5.1 specifically since Detox does not support iOS15 yet. Xcode 12.5.1 uses iOS 14.x
4343

4444
- uses: actions/checkout@v2
4545
with:

tests/package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,7 @@
6060
"build": "xcodebuild VALID_ARCHS=\"`uname -m`\" CC=clang CPLUSPLUS=clang++ LD=clang LDPLUSPLUS=clang++ -workspace ios/testing.xcworkspace -scheme testing -configuration Debug -sdk iphonesimulator -derivedDataPath ios/build -UseModernBuildSystem=YES",
6161
"type": "ios.simulator",
6262
"device": {
63-
"type": "iPhone 11",
64-
"os": "iOS 13.7"
63+
"type": "iPhone 11"
6564
}
6665
},
6766
"ios.sim.release": {

0 commit comments

Comments
 (0)