Skip to content

Commit 789d41b

Browse files
committed
fix(app-check, ios): remove import loop to fix protocol def warning
import loops can apparently be the root cause of protocol definition issues, and if you ensure imports only happen once by chaining correctly then protocol definitions are found correctly and the warning goes away
1 parent e4c57fa commit 789d41b

File tree

3 files changed

+3
-6
lines changed

3 files changed

+3
-6
lines changed

packages/app-check/ios/RNFBAppCheck/RNFBAppCheckModule.m

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,13 @@
1616
*/
1717

1818
#import <Firebase/Firebase.h>
19+
#import <FirebaseAppCheck/FIRAppCheck.h>
20+
1921
#import <React/RCTUtils.h>
2022

2123
#import "RNFBApp/RNFBSharedUtils.h"
2224
#import "RNFBAppCheckModule.h"
2325

24-
#import "FirebaseAppCheck/FIRAppCheck.h"
25-
2626
@implementation RNFBAppCheckModule
2727
#pragma mark -
2828
#pragma mark Module Setup

packages/app-check/ios/RNFBAppCheck/RNFBAppCheckProviderFactory.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
*
1616
*/
1717

18-
#import <FirebaseAppCheck/FIRAppCheck.h>
18+
#import "RNFBAppCheckProvider.h"
1919

2020
@interface RNFBAppCheckProviderFactory : NSObject <FIRAppCheckProviderFactory>
2121

packages/app-check/ios/RNFBAppCheck/RNFBAppCheckProviderFactory.m

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,7 @@
1616
*/
1717

1818
#import "RNFBAppCheckProviderFactory.h"
19-
#import <Firebase/Firebase.h>
20-
#import <FirebaseAppCheck/FIRAppCheck.h>
2119
#import "RNFBApp/RNFBSharedUtils.h"
22-
#import "RNFBAppCheckProvider.h"
2320

2421
@implementation RNFBAppCheckProviderFactory
2522

0 commit comments

Comments
 (0)