build(tests, ios): unify iOS debug build target, remove build filters

react-native 0.64 includes "CodeGen" on the iOS platform, and it was not running
reliably locally for iOS tests (`yarn tests:ios:build`) while xcpretty and quiet were
in use, not sure why. Removing them means it runs reliably though, so this removes them

also devs should use what CI uses philosophically, so unify those targets

Author: mikehardy

.github/workflows/tests_e2e.yml

@@ -301,7 +301,7 @@ jobs:
           export RCT_NO_LAUNCH_PACKAGER=1
           cd tests
           set -o pipefail
-          ./node_modules/.bin/detox build --configuration ios.ci
+          ./node_modules/.bin/detox build --configuration ios.sim.debug
         shell: bash
 
       - name: Install applesimutils
@@ -334,7 +334,7 @@ jobs:
         timeout-minutes: 40
         run: |
           cd tests
-          ./node_modules/.bin/nyc ./node_modules/.bin/detox test --loglevel trace --debug-synchronization 200 --configuration ios.ci --cleanup
+          ./node_modules/.bin/nyc ./node_modules/.bin/detox test --loglevel trace --debug-synchronization 200 --configuration ios.sim.debug --cleanup
 
       - name: Compress Simulator Log
         if: always()

tests/package.json

@@ -52,15 +52,15 @@
     "configurations": {
       "ios.sim.debug": {
         "binaryPath": "ios/build/Build/Products/Debug-iphonesimulator/testing.app",
-        "build": "set -o pipefail && xcodebuild -workspace ios/testing.xcworkspace -scheme testing -configuration Debug -sdk iphonesimulator -derivedDataPath ios/build -UseModernBuildSystem=YES -quiet | xcpretty -k",
+        "build": "xcodebuild -workspace ios/testing.xcworkspace -scheme testing -configuration Debug -sdk iphonesimulator -derivedDataPath ios/build -UseModernBuildSystem=YES",
         "type": "ios.simulator",
         "device": {
-          "type": "iPhone 8"
+          "type": "iPhone 11"
         }
       },
-      "ios.ci": {
-        "binaryPath": "ios/build/Build/Products/Debug-iphonesimulator/testing.app",
-        "build": "set -o pipefail && xcodebuild -workspace ios/testing.xcworkspace -scheme testing -configuration Debug -sdk iphonesimulator -derivedDataPath ios/build -UseModernBuildSystem=YES | xcpretty -k",
+      "ios.sim.release": {
+        "binaryPath": "ios/build/Build/Products/Release-iphonesimulator/testing.app",
+        "build": "export RCT_NO_LAUNCH_PACKAGER=true && xcodebuild -workspace ios/testing.xcworkspace -scheme testing -configuration Release -sdk iphonesimulator -derivedDataPath ios/build -UseModernBuildSystem=YES",
         "type": "ios.simulator",
         "device": {
           "type": "iPhone 11"
@@ -74,14 +74,6 @@
           "avdName": "TestingAVD"
         }
       },
-      "ios.sim.release": {
-        "binaryPath": "ios/build/Build/Products/Release-iphonesimulator/testing.app",
-        "build": "set -o pipefail && export RCT_NO_LAUNCH_PACKAGER=true && xcodebuild -workspace ios/testing.xcworkspace -scheme testing -configuration Release -sdk iphonesimulator -derivedDataPath ios/build -UseModernBuildSystem=YES -quiet | xcpretty -k",
-        "type": "ios.simulator",
-        "device": {
-          "type": "iPhone X"
-        }
-      },
       "android.emu.release": {
         "binaryPath": "android/app/build/outputs/apk/release/app-release.apk",
         "build": "cd android && ./gradlew assembleRelease assembleAndroidTest -DtestBuildType=release && cd ..",