Skip to content

Commit 8e80233

Browse files
committed
test(storage): note upstream SDK/emulator issue links
There are a few SDK and emulator issues we are tracking that do not allow tests to pass if all API expectations are probed with assertions
1 parent d602436 commit 8e80233

File tree

1 file changed

+11
-6
lines changed

1 file changed

+11
-6
lines changed

packages/storage/e2e/StorageReference.e2e.js

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -191,8 +191,11 @@ describe('storage() -> StorageReference', function () {
191191
metadata.generation.should.be.a.String();
192192
metadata.fullPath.should.equal(`${PATH}/list/file1.txt`);
193193
if (device.getPlatform() === 'android') {
194-
// FIXME - iOS on emulator this is fullPath not name ?
195194
metadata.name.should.equal('file1.txt');
195+
} else {
196+
// FIXME on ios file comes through as fully-qualified
197+
// https://github.com/firebase/firebase-ios-sdk/issues/9849#issuecomment-1159819958
198+
metadata.name.should.equal(`${PATH}/list/file1.txt`);
196199
}
197200
metadata.size.should.be.a.Number();
198201
should.equal(metadata.size > 0, true);
@@ -204,6 +207,8 @@ describe('storage() -> StorageReference', function () {
204207
metadata.bucket.should.equal(`${firebase.app().options.projectId}.appspot.com`);
205208
metadata.metageneration.should.be.a.String();
206209
metadata.md5Hash.should.be.a.String();
210+
// TODO against cloud storage cacheControl comes back null/undefined by default. Emulator has a difference
211+
// https://github.com/firebase/firebase-tools/issues/3398#issuecomment-1159821364
207212
should.equal(metadata.cacheControl, 'public, max-age=3600');
208213
should.equal(metadata.contentLanguage, null);
209214
should.equal(metadata.customMetadata, null);
@@ -370,10 +375,10 @@ describe('storage() -> StorageReference', function () {
370375
metadata.generation.should.be.a.String();
371376
metadata.fullPath.should.equal(`${PATH}/list/file1.txt`);
372377
if (device.getPlatform() === 'android') {
373-
// FIXME on android file comes through as fully-qualified
374-
// TODO log issue with firebase-tools repository
375378
metadata.name.should.equal('file1.txt');
376379
} else {
380+
// FIXME on ios file comes through as fully-qualified
381+
// https://github.com/firebase/firebase-ios-sdk/issues/9849#issuecomment-1159819958
377382
metadata.name.should.equal(`${PATH}/list/file1.txt`);
378383
}
379384
metadata.size.should.be.a.Number();
@@ -409,10 +414,10 @@ describe('storage() -> StorageReference', function () {
409414
metadata.generation.should.be.a.String();
410415
metadata.fullPath.should.equal(`${PATH}/list/file1.txt`);
411416
if (device.getPlatform() === 'android') {
412-
// FIXME on android file comes through as fully-qualified
413-
// TODO log issue with firebase-tools repository
414417
metadata.name.should.equal('file1.txt');
415418
} else {
419+
// FIXME on ios file comes through as fully-qualified
420+
// https://github.com/firebase/firebase-ios-sdk/issues/9849#issuecomment-1159819958
416421
metadata.name.should.equal(`${PATH}/list/file1.txt`);
417422
}
418423
metadata.size.should.be.a.Number();
@@ -425,7 +430,7 @@ describe('storage() -> StorageReference', function () {
425430

426431
// Things that we may set (or remove)
427432
// FIXME for storage emulator values are not cleared. Works against cloud
428-
// TODO log issue with firebase-tools repository
433+
// https://github.com/firebase/firebase-tools/issues/3398#issuecomment-1159821364
429434
// should.equal(metadata.cacheControl, undefined); // fails on android against storage emulator
430435
// should.equal(metadata.contentDisposition, undefined); // fails on android against storage emulator
431436
// should.equal(metadata.contentEncoding, 'identity'); // fails on android against storage emulator

0 commit comments

Comments
 (0)