Skip to content

Commit 93100c7

Browse files
committed
test: ignore errors related to workflow screen recording
the screen recordings are nice to have for forensics, but not an indicator of whether the test run itself is succeeding at same time screen recording setup apperas to fail 3-4% of the time and is now one of the most significant sources of flakiness, so continue if that's the only problem
1 parent 79455d1 commit 93100c7

File tree

2 files changed

+5
-0
lines changed

2 files changed

+5
-0
lines changed

.github/workflows/tests_e2e_ios.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -103,11 +103,13 @@ jobs:
103103
steps:
104104
- name: Setup Environment for Screen Recording
105105
uses: guidepup/[email protected]
106+
continue-on-error: true
106107
with:
107108
record: true
108109

109110
- name: Upload Screen Recording Environment Setup
110111
uses: actions/upload-artifact@v4
112+
continue-on-error: true
111113
if: always()
112114
with:
113115
name: screenrecording-setup-${{ matrix.buildmode }}-${{ matrix.iteration }}.mov

.github/workflows/tests_e2e_other.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -98,11 +98,13 @@ jobs:
9898
steps:
9999
- name: Setup Environment for Screen Recording
100100
uses: guidepup/[email protected]
101+
continue-on-error: true
101102
with:
102103
record: true
103104

104105
- name: Upload Screen Recording Environment Setup
105106
uses: actions/upload-artifact@v4
107+
continue-on-error: true
106108
if: always()
107109
with:
108110
name: screenrecording-setup-${{ matrix.iteration }}.mov
@@ -235,6 +237,7 @@ jobs:
235237
echo "...javascript bundle ready"
236238
237239
- name: Start Screen Recording and System Logging
240+
continue-on-error: true
238241
run: |
239242
nohup sh -c "sleep 314159265 | screencapture -v -C -k -T0 -g screenrecording.mov > screenrecording.log 2>&1 &"
240243
nohup sh -c "log stream --backtrace --color none --style syslog > syslog.log 2>&1 &"

0 commit comments

Comments
 (0)