Skip to content

Commit 97634eb

Browse files
committed
test(firestore): prefer modular namespace in tests that self-interfere
we have a few tests where only one of the modular or namespaced versions can run due to weaknesses in our test fixture usage - switch to running the modular version instead of the namespaced version now
1 parent 6da740f commit 97634eb

File tree

1 file changed

+23
-7
lines changed

1 file changed

+23
-7
lines changed

packages/firestore/e2e/firestore.e2e.js

Lines changed: 23 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,8 @@ describe('firestore()', function () {
219219

220220
describe('settings', function () {
221221
describe('serverTimestampBehavior', function () {
222-
it("handles 'estimate'", async function () {
222+
// TODO flakey in new Jet setup since it conflicts with the modular tests
223+
xit("handles 'estimate'", async function () {
223224
// TODO(ehesp): Figure out how to call settings on other.
224225
if (Platform.other) {
225226
// Not supported on web lite sdk
@@ -246,7 +247,8 @@ describe('firestore()', function () {
246247
await ref.delete();
247248
});
248249

249-
it("handles 'previous'", async function () {
250+
// TODO flakey in new Jet setup since it conflicts with the modular tests
251+
xit("handles 'previous'", async function () {
250252
// TODO(ehesp): Figure out how to call settings on other.
251253
if (Platform.other) {
252254
// Not supported on web lite sdk
@@ -303,7 +305,8 @@ describe('firestore()', function () {
303305
await ref.delete();
304306
});
305307

306-
it("handles 'none'", async function () {
308+
// works in isolation but not in suite
309+
xit("handles 'none'", async function () {
307310
// TODO(ehesp): Figure out how to call settings on other.
308311
if (Platform.other) {
309312
return;
@@ -644,8 +647,12 @@ describe('firestore()', function () {
644647

645648
describe('settings', function () {
646649
describe('serverTimestampBehavior', function () {
647-
// TODO flakey in new Jet setup since it conflicts with the v8 tests
648-
xit("handles 'estimate'", async function () {
650+
it("handles 'estimate'", async function () {
651+
// TODO(ehesp): Figure out how to call settings on other.
652+
if (Platform.other) {
653+
// Not supported on web lite sdk
654+
return;
655+
}
649656
const { initializeFirestore, doc, onSnapshot, setDoc, deleteDoc } = firestoreModular;
650657

651658
const db = await initializeFirestore(firebase.app(), {
@@ -675,6 +682,11 @@ describe('firestore()', function () {
675682
});
676683

677684
it("handles 'previous'", async function () {
685+
// TODO(ehesp): Figure out how to call settings on other.
686+
if (Platform.other) {
687+
// Not supported on web lite sdk
688+
return;
689+
}
678690
const { initializeFirestore, doc, onSnapshot, setDoc, deleteDoc, snapshotEqual } =
679691
firestoreModular;
680692

@@ -734,8 +746,12 @@ describe('firestore()', function () {
734746
await deleteDoc(ref);
735747
});
736748

737-
// FIXME: works in isolation but not in suite
738-
xit("handles 'none'", async function () {
749+
it("handles 'none'", async function () {
750+
// TODO(ehesp): Figure out how to call settings on other.
751+
if (Platform.other) {
752+
// Not supported on web lite sdk
753+
return;
754+
}
739755
const { initializeFirestore, doc, onSnapshot, setDoc, deleteDoc } = firestoreModular;
740756

741757
const db = await initializeFirestore(firebase.app(), {

0 commit comments

Comments
 (0)