fix(analytics, ios): FirebaseAnalytics/Core is always needed

the IdentitySupport case works without this Core pod specified because
of transitive dependencies, but the no-IDFA case (*very* important for
those that need it) failed to include it causing broken builds

Co-authored-by: Mike Hardy <[email protected]>

Author: NikitaDudin

packages/analytics/RNFBAnalytics.podspec

@@ -39,6 +39,7 @@ Pod::Spec.new do |s|
   end
 
   # Firebase dependencies
+  s.dependency          'FirebaseAnalytics/Core', firebase_sdk_version
   if defined?($RNFirebaseAnalyticsWithoutAdIdSupport) && ($RNFirebaseAnalyticsWithoutAdIdSupport == true)
     Pod::UI.puts "#{s.name}: Not installing FirebaseAnalytics/IdentitySupport Pod, no IDFA will be collected."
   else

tests/ios/Podfile.lock

@@ -53,6 +53,15 @@ PODS:
     - FirebaseStorage (~> 11.15.0)
   - FirebaseABTesting (11.15.0):
     - FirebaseCore (~> 11.15.0)
+  - FirebaseAnalytics/Core (11.15.0):
+    - FirebaseCore (~> 11.15.0)
+    - FirebaseInstallations (~> 11.0)
+    - GoogleAppMeasurement/Core (= 11.15.0)
+    - GoogleUtilities/AppDelegateSwizzler (~> 8.1)
+    - GoogleUtilities/MethodSwizzler (~> 8.1)
+    - GoogleUtilities/Network (~> 8.1)
+    - "GoogleUtilities/NSData+zlib (~> 8.1)"
+    - nanopb (~> 3.30910.0)
   - FirebaseAnalytics/IdentitySupport (11.15.0):
     - FirebaseCore (~> 11.15.0)
     - FirebaseInstallations (~> 11.0)
@@ -1799,73 +1808,74 @@ PODS:
     - Yoga
   - RNDeviceInfo (14.0.4):
     - React-Core
-  - RNFBAnalytics (22.2.1):
+  - RNFBAnalytics (22.3.0):
+    - FirebaseAnalytics/Core (= 11.15.0)
     - FirebaseAnalytics/IdentitySupport (= 11.15.0)
     - GoogleAdsOnDeviceConversion
     - React-Core
     - RNFBApp
-  - RNFBApp (22.2.1):
+  - RNFBApp (22.3.0):
     - Firebase/CoreOnly (= 11.15.0)
     - React-Core
-  - RNFBAppCheck (22.2.1):
+  - RNFBAppCheck (22.3.0):
     - Firebase/AppCheck (= 11.15.0)
     - React-Core
     - RNFBApp
-  - RNFBAppDistribution (22.2.1):
+  - RNFBAppDistribution (22.3.0):
     - Firebase/AppDistribution (= 11.15.0)
     - React-Core
     - RNFBApp
-  - RNFBAuth (22.2.1):
+  - RNFBAuth (22.3.0):
     - Firebase/Auth (= 11.15.0)
     - React-Core
     - RNFBApp
-  - RNFBCrashlytics (22.2.1):
+  - RNFBCrashlytics (22.3.0):
     - Firebase/Crashlytics (= 11.15.0)
     - FirebaseCoreExtension
     - React-Core
     - RNFBApp
-  - RNFBDatabase (22.2.1):
+  - RNFBDatabase (22.3.0):
     - Firebase/Database (= 11.15.0)
     - React-Core
     - RNFBApp
-  - RNFBDynamicLinks (22.2.1):
+  - RNFBDynamicLinks (22.3.0):
     - Firebase/DynamicLinks (= 11.15.0)
     - GoogleUtilities/AppDelegateSwizzler
     - React-Core
     - RNFBApp
-  - RNFBFirestore (22.2.1):
+  - RNFBFirestore (22.3.0):
     - Firebase/Firestore (= 11.15.0)
     - React-Core
     - RNFBApp
-  - RNFBFunctions (22.2.1):
+  - RNFBFunctions (22.3.0):
     - Firebase/Functions (= 11.15.0)
     - React-Core
     - RNFBApp
-  - RNFBInAppMessaging (22.2.1):
+  - RNFBInAppMessaging (22.3.0):
     - Firebase/InAppMessaging (= 11.15.0)
     - React-Core
     - RNFBApp
-  - RNFBInstallations (22.2.1):
+  - RNFBInstallations (22.3.0):
     - Firebase/Installations (= 11.15.0)
     - React-Core
     - RNFBApp
-  - RNFBMessaging (22.2.1):
+  - RNFBMessaging (22.3.0):
     - Firebase/Messaging (= 11.15.0)
     - FirebaseCoreExtension
     - React-Core
     - RNFBApp
-  - RNFBML (22.2.1):
+  - RNFBML (22.3.0):
     - React-Core
     - RNFBApp
-  - RNFBPerf (22.2.1):
+  - RNFBPerf (22.3.0):
     - Firebase/Performance (= 11.15.0)
     - React-Core
     - RNFBApp
-  - RNFBRemoteConfig (22.2.1):
+  - RNFBRemoteConfig (22.3.0):
     - Firebase/RemoteConfig (= 11.15.0)
     - React-Core
     - RNFBApp
-  - RNFBStorage (22.2.1):
+  - RNFBStorage (22.3.0):
     - Firebase/Storage (= 11.15.0)
     - React-Core
     - RNFBApp
@@ -2300,23 +2310,23 @@ SPEC CHECKSUMS:
   RecaptchaInterop: 11e0b637842dfb48308d242afc3f448062325aba
   RNCAsyncStorage: 5321442ed26760d7581b26effab82399ea5ff18b
   RNDeviceInfo: d863506092aef7e7af3a1c350c913d867d795047
-  RNFBAnalytics: 9dff124ba4f31042ed4af17c8a2989093444fabe
-  RNFBApp: f632d926ed6e00212c9a8c6e91ff8dfa53801a67
-  RNFBAppCheck: da8855fecb59933d179f4fdf067e10f0571443d2
-  RNFBAppDistribution: ca82077a7d89b88e5f94198a47d78dae0398f83c
-  RNFBAuth: 4865ad188d612396d88059e240a4ecbdf3417bd3
-  RNFBCrashlytics: ee3c8c42acb7985adb0c10349cd2b370f75694ec
-  RNFBDatabase: f228940f0df128dadaa31399193d7f1fc102e169
-  RNFBDynamicLinks: dfcd5bccdf096e6ea1c4356875b51b65f0e991bc
-  RNFBFirestore: 04c2b1ffd11deba3c48cdda151a69ae5e982b35b
-  RNFBFunctions: 23c25a18dcc83bcd9d0b8918e677edce976e462c
-  RNFBInAppMessaging: b1b4eee3fc998bd937046cc3a492f1ef255335d4
-  RNFBInstallations: 322e659c173d7c71597fe67190face6f4043127b
-  RNFBMessaging: b2147fd222c08f19e0db543ca00dcbf27b52f54e
-  RNFBML: e4b1fed949b53a6f0cecf1546dca56e01f482492
-  RNFBPerf: da44d41acc7dc3a47cd4cbb034eb0633060bf6d8
-  RNFBRemoteConfig: c6245dca6943501e76790d8aec135068d5dafc79
-  RNFBStorage: 7d68fc64be5acbd23131780f7998956d0adab8f0
+  RNFBAnalytics: 5cfe8c05a01dad18f089af3df0a4af5057330761
+  RNFBApp: f4375dd56d5cca3c47af4cff25e9a801a7405729
+  RNFBAppCheck: 8ec4e9283afb3d7828c6e26843a080d0c9dea39f
+  RNFBAppDistribution: 7e6cdc3d05f1549b68d039f253f33d70661dc96e
+  RNFBAuth: 4107c9889a628967fddd394c02cfca0410bb9218
+  RNFBCrashlytics: b101c80707727d0044a0b55fad0b8b952a200855
+  RNFBDatabase: f76d9006c51ad211efe36c6d79e2908dd547934d
+  RNFBDynamicLinks: d461e99c1905d17d1d528da745f0f2cbad253a06
+  RNFBFirestore: 942e343c06e3cefcb08742fc14991674e565882c
+  RNFBFunctions: 3ba97516c05e96ea4cedee384896d0aa954fb4d7
+  RNFBInAppMessaging: d96c7ab07c94917d04837d8d6ac26386f7c2bc0c
+  RNFBInstallations: 01a8a5d9f9197be5c09d5da276d5e8a82c09609f
+  RNFBMessaging: d7a9b3652402d9a210bcf8bb535834874a676e6f
+  RNFBML: f9d89ae71931ded81fdc9996a77b80eea708c6a4
+  RNFBPerf: e18283b6a2fc29105d2d044c097aa32d134808cd
+  RNFBRemoteConfig: ef8a9a28dc18e48467d6a323f06a9b4c52ba3790
+  RNFBStorage: b8c0715145a453bb2aeb110e1b134ae3627babdd
   SocketRocket: d4aabe649be1e368d1318fdf28a022d714d65748
   Yoga: 6eb60fc2c0eef63e7d2ef4a56e0a3353534143a2