Skip to content

Commit a97be13

Browse files
committed
test: disable new architecture in the test app
this proves that the test app works with legacy / old architecture when react-native-firebase no longer supports old architecture this should be reverted *and* the app package should detect the use of old architecture and emit a build error so developers see immediately that it is not supported
1 parent d92fbdc commit a97be13

File tree

3 files changed

+23
-42
lines changed

3 files changed

+23
-42
lines changed

tests/android/gradle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ reactNativeArchitectures=armeabi-v7a,arm64-v8a,x86,x86_64
3232
# your application. You should enable this flag either if you want
3333
# to write custom TurboModules/Fabric components OR use libraries that
3434
# are providing them.
35-
newArchEnabled=true
35+
newArchEnabled=false
3636

3737
# Use this property to enable or disable the Hermes JS engine.
3838
# If set to false, you will be using JSC instead.

tests/ios/Podfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ $RNFirebaseAnalyticsEnableAdSupport = true
2828
min_ios_version_supported = 15.1
2929

3030
# Uncomment this to test new architecture
31-
#ENV['RCT_NEW_ARCH_ENABLED'] = '1'
31+
ENV['RCT_NEW_ARCH_ENABLED'] = '0'
3232

3333
# Resolve react_native_pods.rb with node to allow for hoisting
3434
require Pod::Executable.execute_command('node', ['-p',

tests/ios/Podfile.lock

Lines changed: 21 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -1782,26 +1782,7 @@ PODS:
17821782
- React-utils (= 0.78.3)
17831783
- RecaptchaInterop (101.0.0)
17841784
- RNCAsyncStorage (2.2.0):
1785-
- DoubleConversion
1786-
- glog
1787-
- hermes-engine
1788-
- RCT-Folly (= 2024.11.18.00)
1789-
- RCTRequired
1790-
- RCTTypeSafety
17911785
- React-Core
1792-
- React-debug
1793-
- React-Fabric
1794-
- React-featureflags
1795-
- React-graphics
1796-
- React-ImageManager
1797-
- React-NativeModulesApple
1798-
- React-RCTFabric
1799-
- React-rendererdebug
1800-
- React-utils
1801-
- ReactCodegen
1802-
- ReactCommon/turbomodule/bridging
1803-
- ReactCommon/turbomodule/core
1804-
- Yoga
18051786
- RNDeviceInfo (15.0.1):
18061787
- React-Core
18071788
- RNFBAnalytics (23.8.5):
@@ -2574,10 +2555,10 @@ SPEC CHECKSUMS:
25742555
React-performancetimeline: c397114f2c025aa73412a9f21e021b08127fe820
25752556
React-RCTActionSheet: a078d5008632fed31b0024c420ee02e612b317d5
25762557
React-RCTAnimation: b197cc109a896c6ce23981e02e317cfc055f6fda
2577-
React-RCTAppDelegate: f7f1d7362256b7c142d9ab49f980df488101f869
2558+
React-RCTAppDelegate: 6e7e4fcec0d72cbe2ca43a028400ebc027264e8f
25782559
React-RCTBlob: c12d15d40db01ac3fe57c24d3ef5233ff3333da6
2579-
React-RCTFabric: 8cdcde7157a22aac04dfeb579dfc3a1141446846
2580-
React-RCTFBReactNativeSpec: c3a78cb9f2a98146443f1b732a4f21b2ce736abd
2560+
React-RCTFabric: 267c7a5820b3d2c999e94a8b3d861e69faac756b
2561+
React-RCTFBReactNativeSpec: e1f4d2662a8a9fd6da4ae3b6b338c7476b4e992b
25812562
React-RCTImage: 7a3d9d67161c714fa4d9b93820da39a266d0f1ff
25822563
React-RCTLinking: f860b917500cd3974235a48d5b199a74a4ed6c26
25832564
React-RCTNetwork: 6a984ab1b5a81d17a2df6cc02c24b249fb055deb
@@ -2598,27 +2579,27 @@ SPEC CHECKSUMS:
25982579
ReactCodegen: 0c213020a601c6adda74f8826629bff9c6c408d3
25992580
ReactCommon: 7f90ec8358d94ec2a078e11990f6e78542957b11
26002581
RecaptchaInterop: 11e0b637842dfb48308d242afc3f448062325aba
2601-
RNCAsyncStorage: 6a8127b6987dc9fbce778669b252b14c8355c7ce
2582+
RNCAsyncStorage: b44e8a4e798c3e1f56bffccd0f591f674fb9198f
26022583
RNDeviceInfo: 36d7f232bfe7c9b5c494cb7793230424ed32c388
2603-
RNFBAnalytics: 724091497dc3148d4365bb965f10579ef386118b
2604-
RNFBApp: 68767e11ba5b4ca67fd030badd7858d60c96a0b2
2605-
RNFBAppCheck: eff9e5c22f7180fe3d5fcbec282ef1271ea4b15f
2606-
RNFBAppDistribution: ad49f97cdd8b2532c35614642043f3a43eee72be
2607-
RNFBAuth: 4543e3aa1a013d456df97ebb7d2fc34d32ca410b
2608-
RNFBCrashlytics: 38630b1f02b7f73e1533cf0e0f01e0d8c7bc699e
2609-
RNFBDatabase: e5b1dd18b272290e383b21bd48a96aaa0cd8820d
2610-
RNFBFirestore: da47fc62ac518c70b55b4ba86b2edea72acf34d4
2611-
RNFBFunctions: 3ac77ac0dae7d2ca1782e2b5461f7c3b81ea2361
2612-
RNFBInAppMessaging: 5cb645b3eddeb625cc7bbd24c273256c1826d942
2613-
RNFBInstallations: 8613c6fa6620437ef5b2a355374cefb665dfcffd
2614-
RNFBMessaging: 1f1127b89d3d271f0422e02539f2e24136157f52
2615-
RNFBML: 399b6249bc0260fbc653377ac10e84cd51f145eb
2616-
RNFBPerf: 3b829bd5b9ecda31e8a0d4b725830806bdf86a20
2617-
RNFBRemoteConfig: 2b901b3973e5fa739b7b8f0bc6419d6ab16ae143
2618-
RNFBStorage: d2a73bfb5abef21c7f5353e31c68529c0ac2b4bb
2584+
RNFBAnalytics: 99cb83a196b0d727319a787bbce57f2b263654b9
2585+
RNFBApp: 0e6cd4d919d3ca7351c62b5f92e3fcafbef81b21
2586+
RNFBAppCheck: a723b13c06e22e5755e26e8623b96a795a00dfff
2587+
RNFBAppDistribution: 795ca09c59d9935c036392c16fe3f28eac9bc60a
2588+
RNFBAuth: 7013977bff1bfec47e7b4eb2795a9f2af5f0093e
2589+
RNFBCrashlytics: 28e4d3590b1561be16bcae29145c61f715e50da5
2590+
RNFBDatabase: 08dfb9352c173c3b04f39f0396b76dae9e0306b3
2591+
RNFBFirestore: 552d9e8bcb171d735814aa9bd28fc2c917a1d79c
2592+
RNFBFunctions: 95601a8a0c2e08cebb6d4874c2805858cc8f2f9e
2593+
RNFBInAppMessaging: 526eae7904ad593fb7be2894e57ca74922538405
2594+
RNFBInstallations: 667f3fecbb1b5fd3ef9db4ff84af2385bdb25aa1
2595+
RNFBMessaging: 8c52b52329c6e47fc9d570217ce2748c5ada58ec
2596+
RNFBML: 0ce913b3ebd5fa96dc6dd352385a3d24c76b9648
2597+
RNFBPerf: 8aa61fd0f01058416a1ef16700c6603990b03568
2598+
RNFBRemoteConfig: fbb0ef5f4bfc1a623a74348e4fdc4c9b4e7cdc57
2599+
RNFBStorage: f6a772b5dff02a4770992dd331a8b4117e634e97
26192600
SocketRocket: d4aabe649be1e368d1318fdf28a022d714d65748
26202601
Yoga: 3bb1ee33b5133befbd33872601fa46efdd48e841
26212602

2622-
PODFILE CHECKSUM: 3abe8cfe7b06f24b788e90bea320d8ae6ea6d11a
2603+
PODFILE CHECKSUM: 8ab1fee6527d0aab821958648c33357c58e0f681
26232604

26242605
COCOAPODS: 1.16.2

0 commit comments

Comments
 (0)