Skip to content

Commit b1a36d3

Browse files
committed
build(deps): bump node to v18
note that there is a specific issue with node >= v18.16 where jest will throw 'TypeError: Cannot redefine property: performance' so for jest tests we pin it to that specific version everyone else can just use the generic v18
1 parent f02964e commit b1a36d3

File tree

9 files changed

+12
-11
lines changed

9 files changed

+12
-11
lines changed

.github/workflows/create_test_patches.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ jobs:
3636

3737
- uses: actions/setup-node@v3
3838
with:
39-
node-version: 16
39+
node-version: 18
4040

4141
- name: Get yarn cache directory path
4242
id: yarn-cache-dir-path

.github/workflows/docs.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ jobs:
2323
fetch-depth: 1
2424
- uses: actions/setup-node@v3
2525
with:
26-
node-version: 16
26+
node-version: 18
2727
- name: Get yarn cache directory path
2828
id: yarn-cache-dir-path
2929
run: echo "dir=$(yarn cache dir)" >> $GITHUB_OUTPUT

.github/workflows/linting.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ jobs:
2424
fetch-depth: 1
2525
- uses: actions/setup-node@v3
2626
with:
27-
node-version: 16
27+
node-version: 18
2828
- name: Configure JDK
2929
uses: actions/setup-java@v3
3030
with:
@@ -65,7 +65,7 @@ jobs:
6565
fetch-depth: 1
6666
- uses: actions/setup-node@v3
6767
with:
68-
node-version: 16
68+
node-version: 18
6969
- name: Get yarn cache directory path
7070
id: yarn-cache-dir-path
7171
run: echo "dir=$(yarn cache dir)" >> $GITHUB_OUTPUT
@@ -96,7 +96,7 @@ jobs:
9696
fetch-depth: 1
9797
- uses: actions/setup-node@v3
9898
with:
99-
node-version: 16
99+
node-version: 18
100100
- name: Get yarn cache directory path
101101
id: yarn-cache-dir-path
102102
run: echo "dir=$(yarn cache dir)" >> $GITHUB_OUTPUT

.github/workflows/pr_title.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
steps:
2020
- uses: actions/setup-node@v3
2121
with:
22-
node-version: 16
22+
node-version: 18
2323
- uses: amannn/action-semantic-pull-request@v5
2424
with:
2525
validateSingleCommit: true

.github/workflows/publish.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
fetch-depth: 0
2020
- uses: actions/setup-node@v3
2121
with:
22-
node-version: 16
22+
node-version: 18
2323
- name: Yarn Install
2424
uses: nick-fields/retry@v2
2525
with:

.github/workflows/scripts/functions/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
"logs": "firebase functions:log"
1010
},
1111
"engines": {
12-
"node": "16"
12+
"node": "18"
1313
},
1414
"main": "lib/index.js",
1515
"dependencies": {

.github/workflows/tests_e2e_android.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ jobs:
5959
# Set up tool versions
6060
- uses: actions/setup-node@v3
6161
with:
62-
node-version: 16
62+
node-version: 18
6363

6464
- name: Configure JDK
6565
uses: actions/setup-java@v3

.github/workflows/tests_e2e_ios.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ jobs:
3636
# Set up tool versions
3737
- uses: actions/setup-node@v3
3838
with:
39-
node-version: 16
39+
node-version: 18
4040

4141
- name: Configure JDK
4242
uses: actions/setup-java@v3

.github/workflows/tests_jest.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,10 @@ jobs:
3434
- uses: actions/checkout@v3
3535
with:
3636
fetch-depth: 50
37+
# Note, cannot use node > v18.15.0 until https://github.com/facebook/react-native/issues/36440 resolved
3738
- uses: actions/setup-node@v3
3839
with:
39-
node-version: 16
40+
node-version: 18.15.0
4041
- name: Get yarn cache directory path
4142
id: yarn-cache-dir-path
4243
run: echo "dir=$(yarn cache dir)" >> $GITHUB_OUTPUT

0 commit comments

Comments
 (0)