fix(admob): AdEventHandler returns javascript (not native) unsubscribe function (#4920)

anta-semenov · web-flow · commit bff9decdc820 · 2021-02-19T13:12:32.000-05:00
* [bug] Admob listener wrong unsibscribe function

`_setAdEventHandler` method return a wrong unsubscribe function. It should remove js listener, but instead it unsubscribe ad instance from native events and _onAdEventHandler is still could be used by the instance

* fix(AdMob): fix linter error
diff --git a/packages/admob/lib/ads/MobileAd.js b/packages/admob/lib/ads/MobileAd.js
@@ -61,7 +61,7 @@ export default class MobileAd {
 
   _setAdEventHandler(handler) {
     this._onAdEventHandler = handler;
-    return () => this._nativeListener.remove();
+    return () => (this._onAdEventHandler = null);
   }
 
   get adUnitId() {

Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,7 @@ export default class MobileAd {`
`61`	`61`
`62`	`62`	`_setAdEventHandler(handler) {`
`63`	`63`	`this._onAdEventHandler = handler;`
`64`		`- return () => this._nativeListener.remove();`
	`64`	`+ return () => (this._onAdEventHandler = null);`
`65`	`65`	`}`
`66`	`66`
`67`	`67`	`get adUnitId() {`