chore(storage, lint): use strongly typed unknown explicitly

mikehardy · mikehardy · commit c83462492824 · 2022-02-09T18:25:43.000-05:00
fixes warning of incompatible types going into the switch
diff --git a/packages/storage/ios/RNFBStorage/RNFBStorageCommon.m b/packages/storage/ios/RNFBStorage/RNFBStorageCommon.m
@@ -370,13 +370,12 @@ + (NSMutableDictionary *)getDownloadTaskAsDictionary:(FIRStorageTaskSnapshot *)t
       @"totalBytes" : @(task.progress.totalUnitCount)
     } mutableCopy];
   } else {
-    return [@{@"bytesTransferred" : @(0), @"state" : [self getTaskStatus:nil], @"totalBytes" : @(0)}
+    return [@{@"bytesTransferred" : @(0), @"state" : [self getTaskStatus:FIRStorageTaskStatusUnknown], @"totalBytes" : @(0)}
         mutableCopy];
   }
 }
 
 + (NSString *)getTaskStatus:(FIRStorageTaskStatus)status {
-  if (status == nil) return @"unknown";
   if (status == FIRStorageTaskStatusResume || status == FIRStorageTaskStatusProgress) {
     return @"running";
   } else if (status == FIRStorageTaskStatusPause) {

Original file line number	Diff line number	Diff line change
`@@ -370,13 +370,12 @@ + (NSMutableDictionary )getDownloadTaskAsDictionary:(FIRStorageTaskSnapshot )t`
`370`	`370`	`@"totalBytes" : @(task.progress.totalUnitCount)`
`371`	`371`	`} mutableCopy];`
`372`	`372`	`} else {`
`373`		`- return [@{@"bytesTransferred" : @(0), @"state" : [self getTaskStatus:nil], @"totalBytes" : @(0)}`
	`373`	`+ return [@{@"bytesTransferred" : @(0), @"state" : [self getTaskStatus:FIRStorageTaskStatusUnknown], @"totalBytes" : @(0)}`
`374`	`374`	`mutableCopy];`
`375`	`375`	`}`
`376`	`376`	`}`
`377`	`377`
`378`	`378`	`+ (NSString *)getTaskStatus:(FIRStorageTaskStatus)status {`
`379`		`- if (status == nil) return @"unknown";`
`380`	`379`	`if (status == FIRStorageTaskStatusResume \|\| status == FIRStorageTaskStatusProgress) {`
`381`	`380`	`return @"running";`
`382`	`381`	`} else if (status == FIRStorageTaskStatusPause) {`