Skip to content

Commit cb7ed0e

Browse files
committed
fix(deps, ios): FirebaseCoreExtension is not always versioned
for the 10.23.1 patch release, only a few podspecs were versioned upstream, and FirebaseCoreExtension was not one of them, it remained on 10.23.0 If we let that dependency version resolve via semantic specifiers from FirebaseCore's podspec it will get `~> 10` which is adequate for our purposes and is in fact how they reference this pod upstream, so the fix is to just remove the version here and let other specifiers drive the version
1 parent 2cee824 commit cb7ed0e

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

packages/crashlytics/RNFBCrashlytics.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ Pod::Spec.new do |s|
3939

4040
# Firebase dependencies
4141
s.dependency 'Firebase/Crashlytics', firebase_sdk_version
42-
s.dependency 'FirebaseCoreExtension', firebase_sdk_version
42+
s.dependency 'FirebaseCoreExtension'
4343

4444
if defined?($RNFirebaseAsStaticFramework)
4545
Pod::UI.puts "#{s.name}: Using overridden static_framework value of '#{$RNFirebaseAsStaticFramework}'"

packages/messaging/RNFBMessaging.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ Pod::Spec.new do |s|
3939

4040
# Firebase dependencies
4141
s.dependency 'Firebase/Messaging', firebase_sdk_version
42-
s.dependency 'FirebaseCoreExtension', firebase_sdk_version
42+
s.dependency 'FirebaseCoreExtension'
4343

4444
if defined?($RNFirebaseAsStaticFramework)
4545
Pod::UI.puts "#{s.name}: Using overridden static_framework value of '#{$RNFirebaseAsStaticFramework}'"

0 commit comments

Comments
 (0)