Skip to content

Commit d03ab42

Browse files
committed
fix(ios, sdk): constrain transitive dependencies more tightly
some were slipping out to 11.4.0 and causing compilation failures while the majority of the system was still on 11.3.0 we can't set exact versions because some pods don't version while others do (a previous issue) but we *can* set a max for compatibility reasons
1 parent 601e38e commit d03ab42

File tree

17 files changed

+88
-88
lines changed

17 files changed

+88
-88
lines changed

packages/analytics/RNFBAnalytics.podspec

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,13 +45,13 @@ Pod::Spec.new do |s|
4545
raise "Firebase/AnalyticsWithoutAdIdSupport requires firebase-ios-sdk 7.11.0 or greater."
4646
end
4747

48-
s.dependency 'Firebase/AnalyticsWithoutAdIdSupport', firebase_sdk_version
48+
s.dependency 'Firebase/AnalyticsWithoutAdIdSupport', "<= #{firebase_sdk_version}"
4949
else
5050
if !defined?($RNFirebaseAnalyticsWithoutAdIdSupport)
5151
Pod::UI.puts "#{s.name}: Using default Firebase/Analytics with Ad Ids. May require App Tracking Transparency. Not allowed for Kids apps."
5252
Pod::UI.puts "#{s.name}: You may set variable `$RNFirebaseAnalyticsWithoutAdIdSupport=true` in Podfile to use analytics without ad ids."
5353
end
54-
s.dependency 'Firebase/Analytics', firebase_sdk_version
54+
s.dependency 'Firebase/Analytics', "<= #{firebase_sdk_version}"
5555

5656
# Special pod for on-device conversion
5757
if defined?($RNFirebaseAnalyticsEnableAdSupport) && ($RNFirebaseAnalyticsEnableAdSupport == true)
@@ -69,7 +69,7 @@ Pod::Spec.new do |s|
6969
raise "GoogleAppMeasurementOnDeviceConversion requires firebase-ios-sdk 9.0.0 or greater."
7070
end
7171

72-
s.dependency 'GoogleAppMeasurementOnDeviceConversion', firebase_sdk_version
72+
s.dependency 'GoogleAppMeasurementOnDeviceConversion', "<= #{firebase_sdk_version}"
7373
end
7474

7575
if defined?($RNFirebaseAsStaticFramework)

packages/app-check/RNFBAppCheck.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ Pod::Spec.new do |s|
3737
end
3838

3939
# Firebase dependencies
40-
s.dependency 'Firebase/AppCheck', firebase_sdk_version
40+
s.dependency 'Firebase/AppCheck', "<= #{firebase_sdk_version}"
4141

4242
if defined?($RNFirebaseAsStaticFramework)
4343
Pod::UI.puts "#{s.name}: Using overridden static_framework value of '#{$RNFirebaseAsStaticFramework}'"

packages/app-distribution/RNFBAppDistribution.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ Pod::Spec.new do |s|
3737
end
3838

3939
# Firebase dependencies
40-
s.dependency 'Firebase/AppDistribution', firebase_sdk_version
40+
s.dependency 'Firebase/AppDistribution', "<= #{firebase_sdk_version}"
4141

4242
if defined?($RNFirebaseAsStaticFramework)
4343
Pod::UI.puts "#{s.name}: Using overridden static_framework value of '#{$RNFirebaseAsStaticFramework}'"

packages/app/RNFBApp.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ Pod::Spec.new do |s|
3131
end
3232

3333
# Firebase dependencies
34-
s.dependency 'Firebase/CoreOnly', firebase_sdk_version
34+
s.dependency 'Firebase/CoreOnly', "<= #{firebase_sdk_version}"
3535

3636
if defined?($RNFirebaseAsStaticFramework)
3737
Pod::UI.puts "#{s.name}: Using overridden static_framework value of '#{$RNFirebaseAsStaticFramework}'"

packages/auth/RNFBAuth.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ Pod::Spec.new do |s|
3737
end
3838

3939
# Firebase dependencies
40-
s.dependency 'Firebase/Auth', firebase_sdk_version
40+
s.dependency 'Firebase/Auth', "<= #{firebase_sdk_version}"
4141

4242
if defined?($RNFirebaseAsStaticFramework)
4343
Pod::UI.puts "#{s.name}: Using overridden static_framework value of '#{$RNFirebaseAsStaticFramework}'"

packages/crashlytics/RNFBCrashlytics.podspec

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,8 @@ Pod::Spec.new do |s|
3838
end
3939

4040
# Firebase dependencies
41-
s.dependency 'Firebase/Crashlytics', firebase_sdk_version
42-
s.dependency 'FirebaseCoreExtension'
41+
s.dependency 'Firebase/Crashlytics', "<= #{firebase_sdk_version}"
42+
s.dependency 'FirebaseCoreExtension', "<= #{firebase_sdk_version}"
4343

4444
if defined?($RNFirebaseAsStaticFramework)
4545
Pod::UI.puts "#{s.name}: Using overridden static_framework value of '#{$RNFirebaseAsStaticFramework}'"

packages/database/RNFBDatabase.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ Pod::Spec.new do |s|
3737
end
3838

3939
# Firebase dependencies
40-
s.dependency 'Firebase/Database', firebase_sdk_version
40+
s.dependency 'Firebase/Database', "<= #{firebase_sdk_version}"
4141

4242
if defined?($RNFirebaseAsStaticFramework)
4343
Pod::UI.puts "#{s.name}: Using overridden static_framework value of '#{$RNFirebaseAsStaticFramework}'"

packages/dynamic-links/RNFBDynamicLinks.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ Pod::Spec.new do |s|
3737
end
3838

3939
# Firebase dependencies
40-
s.dependency 'Firebase/DynamicLinks', firebase_sdk_version
40+
s.dependency 'Firebase/DynamicLinks', "<= #{firebase_sdk_version}"
4141
s.dependency 'GoogleUtilities/AppDelegateSwizzler'
4242

4343
if defined?($RNFirebaseAsStaticFramework)

packages/firestore/RNFBFirestore.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ Pod::Spec.new do |s|
3737
end
3838

3939
# Firebase dependencies
40-
s.dependency 'Firebase/Firestore', firebase_sdk_version
40+
s.dependency 'Firebase/Firestore', "<= #{firebase_sdk_version}"
4141

4242
if defined?($RNFirebaseAsStaticFramework)
4343
Pod::UI.puts "#{s.name}: Using overridden static_framework value of '#{$RNFirebaseAsStaticFramework}'"

packages/functions/RNFBFunctions.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ Pod::Spec.new do |s|
3737
end
3838

3939
# Firebase dependencies
40-
s.dependency 'Firebase/Functions', firebase_sdk_version
40+
s.dependency 'Firebase/Functions', "<= #{firebase_sdk_version}"
4141

4242
if defined?($RNFirebaseAsStaticFramework)
4343
Pod::UI.puts "#{s.name}: Using overridden static_framework value of '#{$RNFirebaseAsStaticFramework}'"

0 commit comments

Comments
 (0)