Skip to content

Commit d874e15

Browse files
dhennekemikehardy
authored andcommitted
fix(firestore): fix types for the where api in modular queries
1 parent ad40ea2 commit d874e15

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

packages/firestore/lib/modular/query.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ export interface AppliableConstraint {
4040
* can then be passed to {@link (query:1)} to create a new query instance that
4141
* also contains this `QueryConstraint`.
4242
*/
43-
export interface IQueryConstraint extends AppliableConstraint {
43+
export interface QueryConstraint extends AppliableConstraint {
4444
/** The type of this query constraint */
4545
readonly type: QueryConstraintType;
4646

packages/firestore/type-test.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ import firebase, {
1515
query,
1616
startAfter,
1717
updateDoc,
18+
where,
1819
} from '.';
1920

2021
console.log(firebase().collection);
@@ -50,6 +51,7 @@ firebase.firestore.setLogLevel('debug');
5051
firebase.firestore().collection('foo');
5152
firebase.firestore().collection('foo').doc('foo').collection('foo');
5253
firebase.firestore().collection('foo').doc('foo');
54+
firebase.firestore().collection('foo').where('foo', '==', 'bar');
5355
firebase.firestore().collection('foo').doc('foo').collection('foo').add({ foo: 'bar' }).then();
5456
firebase.firestore().collection('foo').doc('foo').update({ foo: 'bar' }).then();
5557
firebase
@@ -130,6 +132,7 @@ collection(firebase.firestore(), 'foo', 'foo', 'foo');
130132
collection(doc(collection(firebase.firestore(), 'foo'), 'foo'), 'foo');
131133
doc(firebase.firestore(), 'foo', 'foo');
132134
doc(collection(firebase.firestore(), 'foo'), 'foo');
135+
query(collection(firebase.firestore(), 'foo'), where('foo', '==', 'bar'));
133136
addDoc(collection(firebase.firestore(), 'foo'), { foo: 'bar' }).then();
134137
updateDoc(doc(firebase.firestore(), 'foo', 'foo'), { foo: 'bar' }).then();
135138
getDoc(doc(firebase.firestore(), 'foo', 'foo')).then();

0 commit comments

Comments
 (0)