Skip to content

Commit d9b7175

Browse files
fix(performance): initializePerformance settings param is optional (#8385)
1 parent 110c006 commit d9b7175

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

packages/perf/lib/modular/index.d.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,12 +39,12 @@ type PerformanceSettings = {
3939
/**
4040
* Returns a Performance instance for the given app.
4141
* @param app - FirebaseApp. Required.
42-
* @param settings - PerformanceSettings. Set "dataCollectionEnabled" which will enable/disable Performance collection.
42+
* @param settings - Optional PerformanceSettings. Set "dataCollectionEnabled" which will enable/disable Performance collection.
4343
* @returns {Promise<Performance>}
4444
*/
4545
export function initializePerformance(
4646
app: FirebaseApp,
47-
settings: PerformanceSettings,
47+
settings?: PerformanceSettings,
4848
): Promise<Performance>;
4949

5050
/**

packages/perf/lib/modular/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ export function getPerformance(app) {
4242
/**
4343
* Returns a Performance instance for the given app.
4444
* @param app - FirebaseApp. Required.
45-
* @param settings - PerformanceSettings. Set "dataCollectionEnabled" which will enable/disable Performance collection.
45+
* @param settings - Optional PerformanceSettings. Set "dataCollectionEnabled" which will enable/disable Performance collection.
4646
* @returns {Performance}
4747
*/
4848
export async function initializePerformance(app, settings) {

0 commit comments

Comments
 (0)