test(ios): bump detox / workaround detox emulator app terminate issue

Author: mikehardy

tests/package.json

@@ -34,7 +34,7 @@
     "@react-native-firebase/private-tests-helpers": "0.0.13",
     "a2a": "^0.2.0",
     "babel-plugin-istanbul": "^6.0.0",
-    "detox": "^19.7.1",
+    "detox": "^19.9.1",
     "firebase": "^9.8.3",
     "firebase-tools": "11.6.0",
     "jest-circus": "^28.1.1",

tests/patches/detox+19.7.1.patch renamed to tests/patches/detox+19.9.1.patch

@@ -93,3 +93,18 @@ index fb4b820..d2dc87d 100644
          notifyIdle()
          return true
      }
+diff --git a/node_modules/detox/src/devices/common/drivers/ios/tools/AppleSimUtils.js b/node_modules/detox/src/devices/common/drivers/ios/tools/AppleSimUtils.js
+index afedcf6..a14951a 100644
+--- a/node_modules/detox/src/devices/common/drivers/ios/tools/AppleSimUtils.js
++++ b/node_modules/detox/src/devices/common/drivers/ios/tools/AppleSimUtils.js
+@@ -246,7 +246,9 @@ class AppleSimUtils {
+       // ```
+       // This workaround is done to ignore the error above, as we do not care if the app was running before, we just
+       // want to make sure it isn't now.
+-      if (err.code === 3 && err.stderr.includes(`the app is not currently running`)) {
++      if (err.code === 3 && 
++        (err.stderr.includes(`the app is not currently running`) ||
++         err.stderr.includes(`The operation couldn’t be completed. found nothing to terminate`))) {
+         return;
+       }
+ 

yarn.lock

@@ -6179,10 +6179,10 @@ detect-newline@^3.0.0:
   resolved "https://registry.yarnpkg.com/detect-newline/-/detect-newline-3.1.0.tgz#576f5dfc63ae1a192ff192d8ad3af6308991b651"
   integrity sha512-TLz+x/vEXm/Y7P7wn1EJFNLxYpUD4TgMosxY6fAVJUnJMbupHBOncxyWUG9OpTaH9EBD7uFI5LfEgmMOc54DsA==
 
-detox@^19.7.1:
-  version "19.7.1"
-  resolved "https://registry.yarnpkg.com/detox/-/detox-19.7.1.tgz#1c4dfebbb024426118dfae97a0189a25021479fa"
-  integrity sha512-V0XwiaFX1LvIjLl+G4tzMZ0M4YqenQXAdTsw9kO2dVo6NC9RuYqOIsmT9M3CRN9PF22TKJ8pFdA6onYhH/zkiQ==
+detox@^19.9.1:
+  version "19.9.1"
+  resolved "https://registry.yarnpkg.com/detox/-/detox-19.9.1.tgz#5f357b5e6bc6a4249e01ce9e0dc6cbca956b3241"
+  integrity sha512-SNhmS6VMycYVF/FHNfPR7rhpc/G/ft4c/Pqv6qt3TasBBjfdw5uI7SBAmIPMkPRkWtmAGdRycrFeJGFtBzpriA==
   dependencies:
     ajv "^8.6.3"
     bunyan "^1.8.12"