Skip to content

Commit de22257

Browse files
committed
test(e2e, windows): allow android e2e to run on windows
there was a serious problem with config file discovery for the firebase emulator suite, this forces the location, then all the tests for android appear to work well there was a second problem where the emulator UI port was taken, this lets it float
1 parent 6a1753d commit de22257

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

.github/workflows/scripts/firebase.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,7 @@
3333
"port": "9199"
3434
},
3535
"ui": {
36-
"enabled": true,
37-
"port": 4000
36+
"enabled": true
3837
}
3938
}
4039
}
Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1,6 @@
1-
yarn firebase emulators:start --only auth,database,firestore,functions,storage --project react-native-firebase-testing
1+
@REM this pushd is likely not needed, but just in case
2+
pushd "%~dp0"
3+
@REM this is just to see what our current directory is. Should be .github/workflow/scripts
4+
echo %cd%
5+
@REM strangely, unless you specify the config file as being right in the current directory, it won't find it, and everything fails
6+
yarn firebase emulators:start --config %cd%\firebase.json --only auth,database,firestore,functions,storage --project react-native-firebase-testing

0 commit comments

Comments
 (0)