test(lint): eslint warnings will fail the build now

In practice the previous setup of reporting and annotating meant eslint warnings were ignored, even
though the codebase is actually clean (except one item, fixed here)

Author: mikehardy

.github/workflows/linting.yml

@@ -42,20 +42,6 @@ jobs:
           command: yarn --no-audit --prefer-offline
       - name: Lint
         run: yarn lint
-      - name: Save Code Linting Report JSON
-        run: yarn lint:report
-        continue-on-error: true
-      - name: Annotate Code Linting Results
-        uses: ataylorme/[email protected]
-        continue-on-error: true
-        with:
-          repo-token: '${{ secrets.GITHUB_TOKEN }}'
-          report-json: 'eslint-report.json'
-      - name: Upload ESLint report
-        uses: actions/upload-artifact@v2
-        with:
-          name: eslint-report.json
-          path: eslint-report.json
 
   typescript:
     name: TypeScript Build Validation

package.json

@@ -6,7 +6,7 @@
     "prepare": "yarn run lerna:link && lerna run prepare --parallel",
     "build:all:clean": "lerna run build:clean",
     "build:all:build": "lerna run build",
-    "lint": "eslint . --ext .js,.jsx,.ts,.tsx",
+    "lint": "eslint . --ext .js,.jsx,.ts,.tsx --max-warnings=0",
     "lint:markdown": "prettier --check \"docs/**/*.md\"",
     "lint:report": "eslint --output-file=eslint-report.json --format=json . --ext .js,.jsx,.ts,.tsx",
     "lint:spellcheck": "spellchecker --quiet --files=\"docs/**/*.md\" --dictionaries=\"./.spellcheck.dict.txt\" --reports=\"spelling.json\" --plugins spell indefinite-article repeated-words syntax-mentions syntax-urls frontmatter",