Possible to add custom keys to crashlytics reports

[Nikooos]

In the native SDK it is possible to add custom keys to the Crashlytics reports by using setCustomKey or setCustomValue. I don't see this (yet) in the react native library as far as I know. Of course I could write a bridge and send it through the native sdk, but I'm not using a bridge now and it would bring extra complexity to my app.

What I want to do is send the current redux state with the crash by setting the latest state as a custom value on every state change. This way I know which state the app is in when the crash occurs. For now I'm using the logs, but that's not the way I want to go.

Am I missing something or do you have other suggestions on how to handle this?

https://firebase.google.com/docs/crashlytics/customize-crash-reports?platform=ios#add-keys

[mikehardy]

Hi there! Internally, setAttribute and setAttributes are mapped to setCustomKey(s)

https://rnfirebase.io/reference/crashlytics#setAttribute

react-native-firebase/packages/crashlytics/lib/index.js

Line 89 in 46556de

return this.native.setAttribute(name, value);

react-native-firebase/packages/crashlytics/android/src/main/java/io/invertase/firebase/crashlytics/ReactNativeFirebaseCrashlyticsModule.java

Lines 110 to 132 in 46556de

	@ReactMethod
	public void setAttribute(String key, String value, Promise promise) {
	if (ReactNativeFirebaseCrashlyticsInitProvider.isCrashlyticsCollectionEnabled()) {
	FirebaseCrashlytics.getInstance().setCustomKey(key, value);
	}
	promise.resolve(null);
	}
	@ReactMethod
	public void setAttributes(ReadableMap keyValuesMap, Promise promise) {
	if (ReactNativeFirebaseCrashlyticsInitProvider.isCrashlyticsCollectionEnabled()) {
	ReadableMapKeySetIterator iterator = keyValuesMap.keySetIterator();
	FirebaseCrashlytics crashlytics = FirebaseCrashlytics.getInstance();
	while (iterator.hasNextKey()) {
	String key = iterator.nextKey();
	String value = keyValuesMap.getString(key);
	crashlytics.setCustomKey(key, value);
	}
	}
	promise.resolve(null);
	}

The code's always available to check and it's organized pretty well here, knowing the same may be useful in the future in case you need it

Not sure why our API naming doesn't match up exactly yet - the project's been running for years so it's probably some historical artifact - but I noted it myself a while ago. If you wanted to add to index.d.ts / index.js a set of APIs called setAttribute/setAttributes that had the same javascript implementation, then just call the current ones from the correct naming that'd be a great PR for future folks

[Nikooos]

I'm sorry, I stopped diving in the code when I saw the name. But that is exactly what I need.

I'll try to make a nice PR for it. Thanks for the clarification.

[mikehardy]

Great! Glad that helped, and sorry again for the API mismatch, leads to obvious confusion. No obligation of course but if you did post that PR I would give you all of may available internet points for the day 😆 😄