Skip to content

Commit 6dc1dbb

Browse files
committed
fix(android): remove unnecessary context arg in native module constructors
1 parent 91f4755 commit 6dc1dbb

File tree

4 files changed

+5
-10
lines changed

4 files changed

+5
-10
lines changed

android/src/main/java/io/invertase/googlemobileads/ReactNativeGoogleMobileAdsMediaViewManager.kt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,7 @@ import com.facebook.react.viewmanagers.RNGoogleMobileAdsMediaViewManagerDelegate
2727
import com.facebook.react.viewmanagers.RNGoogleMobileAdsMediaViewManagerInterface
2828

2929
@ReactModule(name = ReactNativeGoogleMobileAdsMediaViewManager.NAME)
30-
class ReactNativeGoogleMobileAdsMediaViewManager(
31-
reactContext: ReactApplicationContext
32-
) : ViewGroupManager<ReactNativeGoogleMobileAdsMediaView>(reactContext),
30+
class ReactNativeGoogleMobileAdsMediaViewManager : ViewGroupManager<ReactNativeGoogleMobileAdsMediaView>(),
3331
RNGoogleMobileAdsMediaViewManagerInterface<ReactNativeGoogleMobileAdsMediaView> {
3432
private val delegate: ViewManagerDelegate<ReactNativeGoogleMobileAdsMediaView> = RNGoogleMobileAdsMediaViewManagerDelegate(this)
3533

android/src/main/java/io/invertase/googlemobileads/ReactNativeGoogleMobileAdsNativeAdViewManager.kt

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ package io.invertase.googlemobileads
1818
*/
1919

2020
import android.view.View
21-
import com.facebook.react.bridge.ReactApplicationContext
2221
import com.facebook.react.bridge.ReactMethod
2322
import com.facebook.react.module.annotations.ReactModule
2423
import com.facebook.react.uimanager.ThemedReactContext
@@ -29,9 +28,7 @@ import com.facebook.react.viewmanagers.RNGoogleMobileAdsNativeViewManagerDelegat
2928
import com.facebook.react.viewmanagers.RNGoogleMobileAdsNativeViewManagerInterface
3029

3130
@ReactModule(name = ReactNativeGoogleMobileAdsNativeAdViewManager.NAME)
32-
class ReactNativeGoogleMobileAdsNativeAdViewManager(
33-
reactContext: ReactApplicationContext
34-
) : ViewGroupManager<ReactNativeGoogleMobileAdsNativeAdView>(reactContext),
31+
class ReactNativeGoogleMobileAdsNativeAdViewManager : ViewGroupManager<ReactNativeGoogleMobileAdsNativeAdView>(),
3532
RNGoogleMobileAdsNativeViewManagerInterface<ReactNativeGoogleMobileAdsNativeAdView> {
3633
private val delegate: ViewManagerDelegate<ReactNativeGoogleMobileAdsNativeAdView> = RNGoogleMobileAdsNativeViewManagerDelegate(this)
3734

android/src/main/java/io/invertase/googlemobileads/ReactNativeGoogleMobileAdsNativeModule.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ import com.google.android.gms.ads.VideoOptions
3131
import com.google.android.gms.ads.nativead.NativeAd
3232
import com.google.android.gms.ads.nativead.NativeAdOptions
3333

34-
@ReactModule(ReactNativeGoogleMobileAdsNativeModule.NAME)
34+
@ReactModule(name = ReactNativeGoogleMobileAdsNativeModule.NAME)
3535
class ReactNativeGoogleMobileAdsNativeModule(
3636
reactContext: ReactApplicationContext
3737
) : NativeGoogleMobileAdsNativeModuleSpec(reactContext) {

android/src/main/java/io/invertase/googlemobileads/ReactNativeGoogleMobileAdsPackage.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ class ReactNativeGoogleMobileAdsPackage : TurboReactPackage() {
3131
): List<ViewManager<*, *>> {
3232
return listOf(
3333
ReactNativeGoogleMobileAdsBannerAdViewManager(),
34-
ReactNativeGoogleMobileAdsNativeAdViewManager(reactContext),
35-
ReactNativeGoogleMobileAdsMediaViewManager(reactContext)
34+
ReactNativeGoogleMobileAdsNativeAdViewManager(),
35+
ReactNativeGoogleMobileAdsMediaViewManager()
3636
)
3737
}
3838

0 commit comments

Comments
 (0)