fix(android): add TurboModule support for RNAppModule on RN 0.83+

This fixes the runtime crash "TurboModuleRegistry.getEnforcing(...):
'RNAppModule' not found" when using React Native 0.83+ with mandatory
New Architecture.

Changes:
- Create NativeAppModule.ts TurboModule spec for Codegen
- Update ReactNativeAppModule.java to extend NativeAppModuleSpec
- Update GoogleMobileAdsNativeEventEmitter.ts to use TurboModule import
- Enable isTurboModule flag for RNAppModule in Package.kt

The RNAppModule (internal event handling module) was the only module
not properly configured as a TurboModule. While other modules like
RNGoogleMobileAdsModule had proper TurboModule support, RNAppModule
extended ReactNativeModule (bridge-based) and had isTurboModule=false
hardcoded in the package registration.

Fixes #XXX

Author: Pato9310

android/src/main/java/io/invertase/googlemobileads/ReactNativeAppModule.java

@@ -17,6 +17,7 @@
  *
  */
 
+import androidx.annotation.NonNull;
 import com.facebook.react.bridge.Promise;
 import com.facebook.react.bridge.ReactApplicationContext;
 import com.facebook.react.bridge.ReactMethod;
@@ -26,62 +27,54 @@
 import io.invertase.googlemobileads.common.ReactNativeEventEmitter;
 import io.invertase.googlemobileads.common.ReactNativeJSON;
 import io.invertase.googlemobileads.common.ReactNativeMeta;
-import io.invertase.googlemobileads.common.ReactNativeModule;
 import io.invertase.googlemobileads.common.ReactNativePreferences;
 
-public class ReactNativeAppModule extends ReactNativeModule {
-  static final String NAME = "RNAppModule";
+public class ReactNativeAppModule extends NativeAppModuleSpec {
+  public static final String NAME = NativeAppModuleSpec.NAME;
 
   ReactNativeAppModule(ReactApplicationContext reactContext) {
-    super(reactContext, NAME);
+    super(reactContext);
   }
 
   @Override
   public void initialize() {
     super.initialize();
-    ReactNativeEventEmitter.getSharedInstance().attachReactContext(getContext());
+    ReactNativeEventEmitter.getSharedInstance().attachReactContext(getReactApplicationContext());
   }
 
+  @Override
   @ReactMethod
   public void initializeApp(ReadableMap options, ReadableMap appConfig, Promise promise) {
-    // ReactNativeApp reactNativeApp =
-    //     RCTConvertFirebase.readableMapToFirebaseApp(options, appConfig, getContext());
-
-    // WritableMap reactNativeAppMap =
-    // RCTConvertFirebase.reactNativeAppToWritableMap(reactNativeApp);
-    // promise.resolve(reactNativeAppMap);
     promise.resolve(options);
   }
 
+  @Override
   @ReactMethod
-  public void setAutomaticDataCollectionEnabled(String appName, Boolean enabled) {
-    // ReactNativeApp reactNativeApp = ReactNativeApp.getInstance(appName);
-    // reactNativeApp.setDataCollectionDefaultEnabled(enabled);
+  public void setAutomaticDataCollectionEnabled(String appName, boolean enabled) {
+    // No-op for ads module
   }
 
+  @Override
   @ReactMethod
   public void deleteApp(String appName, Promise promise) {
-    // ReactNativeApp reactNativeApp = ReactNativeApp.getInstance(appName);
-
-    // if (reactNativeApp != null) {
-    //   reactNativeApp.delete();
-    // }
-
     promise.resolve(null);
   }
 
+  @Override
   @ReactMethod
-  public void eventsNotifyReady(Boolean ready) {
+  public void eventsNotifyReady(boolean ready) {
     ReactNativeEventEmitter emitter = ReactNativeEventEmitter.getSharedInstance();
     emitter.notifyJsReady(ready);
   }
 
+  @Override
   @ReactMethod
   public void eventsGetListeners(Promise promise) {
     ReactNativeEventEmitter emitter = ReactNativeEventEmitter.getSharedInstance();
     promise.resolve(emitter.getListenersMap());
   }
 
+  @Override
   @ReactMethod
   public void eventsPing(String eventName, ReadableMap eventBody, Promise promise) {
     ReactNativeEventEmitter emitter = ReactNativeEventEmitter.getSharedInstance();
@@ -90,58 +83,68 @@ public void eventsPing(String eventName, ReadableMap eventBody, Promise promise)
     promise.resolve(RCTConvert.readableMapToWritableMap(eventBody));
   }
 
+  @Override
   @ReactMethod
   public void eventsAddListener(String eventName) {
     ReactNativeEventEmitter emitter = ReactNativeEventEmitter.getSharedInstance();
     emitter.addListener(eventName);
   }
 
+  @Override
   @ReactMethod
-  public void eventsRemoveListener(String eventName, Boolean all) {
+  public void eventsRemoveListener(String eventName, boolean all) {
     ReactNativeEventEmitter emitter = ReactNativeEventEmitter.getSharedInstance();
     emitter.removeListener(eventName, all);
   }
 
+  @Override
   @ReactMethod
   public void addListener(String eventName) {
     // Keep: Required for RN built in Event Emitter Calls.
   }
 
+  @Override
   @ReactMethod
-  public void removeListeners(Integer count) {
+  public void removeListeners(double count) {
     // Keep: Required for RN built in Event Emitter Calls.
   }
 
   /** ------------------ META ------------------ */
+  @Override
   @ReactMethod
   public void metaGetAll(Promise promise) {
     promise.resolve(ReactNativeMeta.getSharedInstance().getAll());
   }
 
   /** ------------------ JSON ------------------ */
+  @Override
   @ReactMethod
   public void jsonGetAll(Promise promise) {
     promise.resolve(ReactNativeJSON.getSharedInstance().getAll());
   }
 
   /** ------------------ PREFERENCES ------------------ */
+  @Override
   @ReactMethod
   public void preferencesSetBool(String key, boolean value, Promise promise) {
     ReactNativePreferences.getSharedInstance().setBooleanValue(key, value);
     promise.resolve(null);
   }
 
+  @Override
   @ReactMethod
   public void preferencesSetString(String key, String value, Promise promise) {
     ReactNativePreferences.getSharedInstance().setStringValue(key, value);
     promise.resolve(null);
   }
 
+  @Override
   @ReactMethod
   public void preferencesGetAll(Promise promise) {
     promise.resolve(ReactNativePreferences.getSharedInstance().getAll());
   }
 
+  @Override
   @ReactMethod
   public void preferencesClearAll(Promise promise) {
     ReactNativePreferences.getSharedInstance().clearAll();

android/src/main/java/io/invertase/googlemobileads/ReactNativeGoogleMobileAdsPackage.kt

@@ -57,11 +57,11 @@ class ReactNativeGoogleMobileAdsPackage : TurboReactPackage() {
       moduleInfos[ReactNativeAppModule.NAME] =
         ReactModuleInfo(
           ReactNativeAppModule.NAME,
-          ReactNativeAppModule.NAME,
+          ReactNativeAppModule::class.java.name,
           false, // canOverrideExistingModule
           false, // needsEagerInit
           false, // isCxxModule
-          false,  // isTurboModule
+          isTurboModule,
         )
       moduleInfos[ReactNativeGoogleMobileAdsModule.NAME] =
         ReactModuleInfo(

src/internal/GoogleMobileAdsNativeEventEmitter.ts

@@ -15,15 +15,10 @@
  *
  */
 
-import { NativeEventEmitter, NativeModules, NativeModule } from 'react-native';
+import { NativeEventEmitter } from 'react-native';
+import NativeAppModule from '../specs/modules/NativeAppModule';
 
-type RNAppNativeModule = {
-  eventsNotifyReady: (ready: boolean) => void;
-  eventsAddListener: (eventType: string) => void;
-  eventsRemoveListener: (eventType: string, FIXME: boolean) => void;
-} & NativeModule;
-
-const RNAppModule = NativeModules.RNAppModule as RNAppNativeModule;
+const RNAppModule = NativeAppModule;
 
 class GANativeEventEmitter extends NativeEventEmitter {
   ready: boolean;

src/specs/modules/NativeAppModule.ts

@@ -0,0 +1,51 @@
+/*
+ * Copyright (c) 2016-present Invertase Limited & Contributors
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this library except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import type { TurboModule } from 'react-native';
+import { TurboModuleRegistry } from 'react-native';
+import type { UnsafeObject } from 'react-native/Libraries/Types/CodegenTypes';
+
+export interface Spec extends TurboModule {
+  // App initialization
+  initializeApp(options: UnsafeObject, appConfig: UnsafeObject): Promise<UnsafeObject>;
+  setAutomaticDataCollectionEnabled(appName: string, enabled: boolean): void;
+  deleteApp(appName: string): Promise<void>;
+
+  // Events
+  eventsNotifyReady(ready: boolean): void;
+  eventsGetListeners(): Promise<UnsafeObject>;
+  eventsPing(eventName: string, eventBody: UnsafeObject): Promise<UnsafeObject>;
+  eventsAddListener(eventName: string): void;
+  eventsRemoveListener(eventName: string, all: boolean): void;
+
+  // Required for RN built-in Event Emitter
+  addListener(eventName: string): void;
+  removeListeners(count: number): void;
+
+  // Meta
+  metaGetAll(): Promise<UnsafeObject>;
+
+  // JSON
+  jsonGetAll(): Promise<UnsafeObject>;
+
+  // Preferences
+  preferencesSetBool(key: string, value: boolean): Promise<void>;
+  preferencesSetString(key: string, value: string): Promise<void>;
+  preferencesGetAll(): Promise<UnsafeObject>;
+  preferencesClearAll(): Promise<void>;
+}
+
+export default TurboModuleRegistry.getEnforcing<Spec>('RNAppModule');