chore(firestore-stripe-payments): updated scripts for CI and local testing (#415)

* chore(firestore-stripe-payments): updated scripts for ci and local testing

* chore(firestore-stripe-payments): added testing typescript configuration, fixes jest warnings in files

* fix(firestore-stripe-web-sdk): locked sinon types to 10.0.6

* chore(firestore-stripe-payments): removed obsolete comments

Author: dackers86

firestore-stripe-payments/functions/__tests__/run-script-watch.ts

@@ -5,32 +5,19 @@ import { setupProxy, cleanupProxy } from './helpers/setupProxy';
 (async () => {
   const proxyId = await setupProxy();
 
-  /* clean stripe webhook on exit */
-  process.on('SIGINT', () => {
-    cleanupProxy(proxyId).then(() => {
-      console.log('Removed webhook ', proxyId);
-      process.exit(0);
-    });
-  });
-
-  await concurrently([
-    {
-      command: 'npx kill-port 5001, npx kill-port 8080',
-      name: 'Ready ports',
-    },
-  ]);
-
-  await concurrently(
+  const { result } = await concurrently(
     [
       {
-        command: 'npm run start:emulator',
-        name: 'emulator',
-      },
-      {
-        command: 'sh ../runTestsWatch.sh',
+        command: 'npm run exec:emulator:watch',
         name: 'testing',
       },
     ],
     {}
   );
+
+  await result.then(async () => {
+    await cleanupProxy(proxyId);
+    console.log('Removed webhook ', proxyId);
+    process.exit(0);
+  });
 })();

firestore-stripe-payments/functions/__tests__/tsconfig.json

@@ -0,0 +1,10 @@
+{
+  "extends": "../tsconfig.json",
+  "compilerOptions": {
+    "lib": ["es2017"],
+    "types": ["../node_modules/stripe/types/2020-08-27", "jest", "node"],
+    "rootDir": "./"
+  },
+  "include": ["../__tests__"],
+  "exclude": ["../node_modules"]
+}

firestore-stripe-payments/functions/package.json

@@ -12,12 +12,11 @@
     "compile": "tsc",
     "generate-readme": "firebase ext:info .. --markdown > ../README.md",
     "test": "ts-node ./__tests__/run-script.ts",
-    "test:local": "ts-node ./__tests__/run-script-watch.ts",
-    "test:watch": "concurrently \"npm run setup:emulator\" \"jest --watch\"",
+    "test:watch": "ts-node ./__tests__/run-script-watch.ts",
     "start:emulator": "cd ../_emulator && firebase emulators:start -P demo-project",
     "exec:emulator": "cd ../_emulator && firebase emulators:exec \"../runTests.sh\" -P demo-project",
-    "setup:webhooks": "ts-node ./__tests__/helpers/setupProxy.ts",
-    "test-coverage": "jest --coverage --detectOpenHandles --forceExit"
+    "exec:emulator:watch": "cd ../_emulator && firebase emulators:exec \"../runTestsWatch.sh\" -P demo-project",
+    "setup:webhooks": "ts-node ./__tests__/helpers/setupProxy.ts"
   },
   "author": "Stripe (https://stripe.com/)",
   "license": "Apache-2.0",

firestore-stripe-payments/runTests.sh

@@ -1,3 +1,3 @@
 #!/usr/bin/env bash
 cd ../functions
-jest
+jest --coverage

firestore-stripe-web-sdk/package.json

@@ -37,7 +37,7 @@
     "@types/chai-as-promised": "^7.1.4",
     "@types/chai-like": "^1.1.1",
     "@types/mocha": "^9.0.0",
-    "@types/sinon": "^10.0.6",
+    "@types/sinon": "10.0.6",
     "@types/sinon-chai": "^3.2.5",
     "chai": "^4.3.4",
     "chai-as-promised": "^7.1.1",