payment_succeeded overwrites payment_failed doc

[albsinger]

Bug report

• Extension name: [e.g. firestore-stripe-payments]

Describe the bug

when a payment fails and then succeeds, the extension creates a doc with the same id as the prior one, overwriting it, instead of creating a new one. This means that the failed payment is not recorded in the db as it is overwritten by the successful one.

To Reproduce

make a failed payment then within the same checkout session (I think) create a successful one.

Expected behavior

create docs with separate ids for each payment failed or succeeded so the entire history is logged.

Screenshots

System information

Additional context

This created a downstream bug for me, as I update user accounts based on documents created, but given that the latter document "created" is actually an update, the user account doesn't update unless I change my code to update the user account on document updated as well.

[albsinger]

PS: I wonder if this issue was created in response to #333.

[albsinger]

Another potential issue:
Apparerently, this is the offending code from insertPaymentRecord

await customersSnap.docs[0].ref
  .collection('payments')
  .doc(payment.id)
  .set(payment, { merge: true });
logs.firestoreDocCreated('payments', payment.id);
};

This will merge the failed and successful payment, leading to merged state of both events.

[albsinger]

Perhaps using the event id instead of using the payment id would fix this, but then there will be separate documents for successful payments and failed ones which may be confusing given the collection name payments.

Alternatively, ignore payments with "type": "payment_intent.payment_failed".