Investbrain
Replies: 13 comments 16 replies
-
|
Hi @nitorrep this is on the roadmap! (Discussion #15) Still tinkering with how this will have to work from a data architecture perspective. So far there have been two struggles with multi-currency support:
Would be interested to hear how the community would tackle these two considerations? |
Beta Was this translation helpful? Give feedback.
-
Chiming in here. Ghostfolio takes a common currency approach, in their case USD, but the way they've implemented it creates a fundamental accounting flaw and makes it completely unusable for anybody dealing in multiple currencies. If I invest $1,000CAD in AAPL, my cost basis must always remain $1,000CAD. What Ghostfolio does is takes that $1,000CAD, converts to USD at the time of the transaction. It then takes that USD amount and converts it back to CAD based on today's exchange rate when calculating return. So my $1,000 CAD cost basis becomes $1,100 today, $950 tmr, $1,005 the next day, etc.. I think the only way to properly implement this is to store the buy transaction in the selected currency and convert the current market value to that selected currency and then run the calculations for return. |
Beta Was this translation helpful? Give feedback.
-
|
I've tinkered with various options here. Your option would work, but could lead to significant memory usage with larger portfolios. Particularly because the "math" happens outside the database during runtime. The ghostfolio approach doesn't take into account backdated transactions and, as you note, performance always uses the current exchange rate - which is memory efficient at the cost of accuracy. I landed on a combination of these solutions. Essentially I convert to a "base currency" but keep the original cost basis/sale price for display purposes. For calculations, I'll be recording daily exchange rates to the database and joining that data in the DB queries. This applies to transactions and dovidends. Letting the DB handle this "math" is slightly more memory hungry, but is much more optimized since it only hits the DB once. As part of the pre-release this week, I'll draw up a quick visual to show how this works. Might also do a quick blog post to demonstrate the pros and cons of each approach. This was a surprisingly tricky issue! |
Beta Was this translation helpful? Give feedback.
-
Overall I see this approach being fine because the ACB will stay constant which is the major flaw of ghostfolio. Just 1 question... How will that work for same-day transactions since daily exchange rates are only published daily at 16:30 ET? If I buy a security today at 13:00 and record it before the daily exchange rate is posted, what exchange rate will be used for that transaction? Will it be stored at current exchange rate for same-day transactions and daily exchange rate when entering historical transactions? |
Beta Was this translation helpful? Give feedback.
-
|
HI @hackeresq , And after on your structure you might define a reference currency at portfolio level and convert transactions (Who could be in any currency) to this main currency, same for valuations. |
Beta Was this translation helpful? Give feedback.
-
|
Any news about this one ? |
Beta Was this translation helpful? Give feedback.
-
|
This one is top priority for me right now! |
Beta Was this translation helpful? Give feedback.
-
|
Hello - is this still planned? As someone not in the US I dunno if InvestBrain will work for me? |
Beta Was this translation helpful? Give feedback.
-
|
Yep, still planned!
Working through some final kinks but multi-currency will be in the next
release. I'll probably mark it as "pre-release" at first since it likely
will have breaking changes (though the plan is to limit those obviously).
…On Mon, Mar 24, 2025, 3:36 PM Dean Pribetic ***@***.***> wrote:
Hello - is this still planned? As someone not in the US I dunno if
InvestBrain will work for me?
—
Reply to this email directly, view it on GitHub
<#62 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD63TFZEXPHT7YEKEDQZE3L2WBUGTAVCNFSM6AAAAABZV4OLUCVHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTENRQG4ZTAMY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
com>
|
Beta Was this translation helpful? Give feedback.
-
|
Currently using Frankfurter <https://frankfurter.dev/> which is also open
source and scrapes data from the European Central Bank. Intra-day exchange
rates will always be a compromise without using commercial "live" data.
Currently I have Investbrain syncing intra-day every 3 hours.
Transactions will be stored like this:
1. Where `currency`of security != `base currency`
2. Convert cost basis (and sale price) to `base currency` using current
(or historic) rate based on date of transaction
3. Store two versions of cost basis - first column is `*_base` (e.g.
`base currency*_base*`) and the other in market currency (e.g.
`cost_basis`) - the same thing is true for dividends where this historical
problem is an issue
Then, when performing performance calculations:
1. For each portfolio, join the `currency rates` table to transactions
on `date` in a subquery
2. Convert the transactions `base currency` to user's `display currency`
in the subquery using the rate on the date of the transaction
3. Sum up all transactions in the `display currency`
This performance query is likely going to get cached since it's slightly
"expensive".
But to your point, there's inevitably going to be edge cases where a rate
wildly swings intra-day. I expect these edge cases to be rare and have a
limited impact on overall performance calculations.
Hope that makes sense? And also open to trying any alternatives if I've
missed anything.
…On Mon, Mar 31, 2025 at 11:00 AM Mike ***@***.***> wrote:
For calculations, I'll be recording daily exchange rates to the database
and joining that data in the DB queries.
Overall I see this approach being fine because the ACB will stay constant
which is the major flaw of ghostfolio.
Just 1 question... How will that work for same-day transactions since
daily exchange rates are only published daily at 16:30 ET? If I buy a
security today at 13:00 and record it before the daily exchange rate is
posted, what exchange rate will be used for that transaction? Will it be
stored at current exchange rate for same-day transactions and daily
exchange rate when entering historical transactions?
—
Reply to this email directly, view it on GitHub
<#62 (reply in thread)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD63TF2CIP23YFVIDP2RFAD2XFRABAVCNFSM6AAAAABZV4OLUCVHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTENRXHA3DENQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
com>
--
Corey
|
Beta Was this translation helpful? Give feedback.
-
|
As a quick update for the folks waiting for multi-currency - very close to publishing the pre-release version (hoping this weekend). Here's what the UI will look like: Portfolio View:
Holding/Transaction View:
Settings page: 
|
Beta Was this translation helpful? Give feedback.
-
|
Will this allow me use to symbols that do not support USD? example: EXIDEIND.NS |
Beta Was this translation helpful? Give feedback.
-
|
That is certainly the goal! 👍 The core is mostly ready, just writing some tests before tagging the pre-release. We're close! |
Beta Was this translation helpful? Give feedback.
-
|
That is amazing! Glad I found this project! |
Beta Was this translation helpful? Give feedback.
-
|
Great news y'all! I've just tagged a pre-release which includes multi-currency support: v1.2.0-alpha. Before spinning up the pre-release, I very much encourage creating a backup (or running separate from your production instance). I very much anticipate there will be bugs and issues. Interested in feedback! |
Beta Was this translation helpful? Give feedback.
-
|
I was able to get it to work, but with mariadb mysql Had this error
Also The currency seems to be working, but I cannot import symbols for other currencies eg: EXIDEIND.NS is this by design? |
Beta Was this translation helpful? Give feedback.
-
|
Having the same issue. Is there a patch available? |
Beta Was this translation helpful? Give feedback.
-
|
This is still pre-release and I'm making many tweaks. I've definitely identified some areas where memory usage spikes and causes issues syncing currency rates. More updates to come soon. But based on your note, I can't really do much. Can you share more specifics on what issue you're facing and steps to reproduce? |
Beta Was this translation helpful? Give feedback.
-
|
When I try to add a symbol from NSE (Indian Exchange, the symbol above EXIDEIND.NS) there is an error that symbol is not valid. It is a valid symbol from yahoo api. |
Beta Was this translation helpful? Give feedback.
-
|
THanks for the additional details. I'll work on reproducing this and do some troubleshooting this weekend. |
Beta Was this translation helpful? Give feedback.
-
|
Trying to test it out but can't get it running at all. |
Beta Was this translation helpful? Give feedback.
-
|
Switching to mariadb in docker compose worked for me |
Beta Was this translation helpful? Give feedback.
-
Do you mind posting your working compose file? |
Beta Was this translation helpful? Give feedback.
-
|
only made changes here mysql:
image: mariadb:10.6
container_name: investbrain-mysql
restart: unless-stopped
environment:
MYSQL_DATABASE: ${DB_DATABASE:-investbrain}
MYSQL_USER: ${DB_USERNAME:-investbrain}
MYSQL_PASSWORD: ${DB_PASSWORD:-investbrain}
MYSQL_ROOT_PASSWORD: ${DB_PASSWORD:-investbrain}
volumes:
- /home/user/investbrain/mysql:/var/lib/mysql
networks:
- investbrain-network |
Beta Was this translation helpful? Give feedback.
-
|
Testing out multi-currency and running into a few issues. On both alpha and beta1 I'm unable to set Locale Options I'm also unable to add non NYSE listed equities Semi-unrelated question, in the add transactions screen, should there be an auto-complete where if I were to start typing AAPL for example, it will give a dropdown to select the right security? If so... this is also not working. If not.... feature request please! lol |
Beta Was this translation helpful? Give feedback.
-
|
Just testing 1.2.0-beta4 and still getting the same. 1 thing I've noticed... aapl will return the symbol provided is not valid, but AAPL is accepted. So it appears the symbol is case sensitive. But it also does not seem to accept Canadian ETF's such as XEQT (also XEQT.TO), ZEQT, XGRO, etc... I assume this has something to do with the data provider. But I also have market provider set EDIT: Just tested and the ability to change locale is also still the same issue. EDIT 2: I'm actually thinking this has something to do with the input form, and not the provider. |
Beta Was this translation helpful? Give feedback.
-
|
Just tried this on 1.2.1 But get an error for all tickers on the TSX. I've tried every combination of XEQT.TO I can think of and get a symbol is not valid. @hackeresq any thoughts? |
Beta Was this translation helpful? Give feedback.
-
|
Very likely this is related to the Yahoo 429 issue (#102). When you create a transaction, there is a validation check to ensure symbols are valid. Can you check your laravel.log file to see if the Yahoo driver is hitting the 429 error? There's a fix in the underlying package for the Yahoo driver, but it requires a bit of re-working the Docker image. I'm working on it now. You can test out the multi currency capabilities on the hosted version: https://investbra.in/dashboard |
Beta Was this translation helpful? Give feedback.
-
|
Going to mark this discussion as closed since v1.2.0 adds multi-currency. Let's move this conversation re: Yahoo 429 issue over to #102. |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
Hi !
I've just tried you app and it seems really promising, do you plain to be able to handle other currency than USD?
I'm from Switzerland and not all my investments are in USD, so it would be great to be able to do so
Beta Was this translation helpful? Give feedback.
All reactions